Pocketmine-mp: Explosions do not drop expected items

[buchwasa]

Issue description

When using an explosion (TNT, explodeA(), etc.) it doesn’t drop every block it should.

• Expected result: The explosion drops stone and other items that require tools to gather.
• Actual result: Only blocks that didn’t require tools to drop spawned.

Steps to reproduce the issue

1. Use any method of an explosion.
2. Check the results on the explosion.
3. Be amazed that only certain blocks dropped.

OS and versions

• PocketMine-MP: fa644edef3db4abaa050cb9cb0aaa94170e132df
• PHP: 7.2.1
• Server OS: Windows 10
• Game version: Both

Plugins

• Test on a clean server without plugins: is the issue reproducible without any plugins loaded?

There are no plugins loaded.
If the issue is not reproducible without plugins:

• Have you asked for help on our forums before creating an issue?
• Can you provide sample, minimal reproducing code for the issue? If so, paste it in the bottom section
• Paste your list of plugins here (use the 'plugins' command in PocketMine-MP)

Crashdump, backtrace or other files

• Do not paste crashdumps into an issue - please use our Crash Archive at https://crash.pmmp.io for submitting crash reports to not spam the issue tracker. Add links to your reports in the Crash Archive here.
• Please use gist or anything else to add other files and add links here
• ...

[Muqsit]

might be due to this https://github.com/pmmp/PocketMine-MP/blob/master/src/pocketmine/level/Explosion.php#L201

$air = ItemFactory::get(Item::AIR);
foreach($blocks as $block){
    foreach($block->getDrops($air) as $drop){...}
}

[buchwasa]

@Muqsit, a temporary fix is changing getDrops to getDropsForCompatibleTool() which doesn’t completely fix it.

[dktapps]

The problem here is that getDrops() requires a compatible tool. However circumventing the tool check is not a correct fix (this will cause tallgrass and other things to drop).

[TheAz928]

@dktapps why not add a new function like getSilkTouchDrops,
$block->getExplosionDrops()?

[dktapps]

I would prefer not adding more methods for this if it can be reasonably avoided.