Pocketmine-mp: Disappearance of GUI after teleport a player.

[matcracker]

Issue description

When you teleport a player with a window opened to another position, the player's GUI disappear.
EDIT:
If you teleport again the player with window opened and GUI disappeared, it will be display the blue sky.

Steps to reproduce the issue

1. Log-in with 2 players.
2. Open a chest with a player.
3. Teleport the player with opened chest to other one.
   EDIT:
4. Open again a chest with the same player who the GUI is disappeared.
5. Teleport the player again.

OS and versions

• PocketMine-MP: https://github.com/pmmp/PocketMine-MP/commit/7c212d3d53f9478cfd48ac1e3f930f1f6c3a4472
• PHP: 7.0
• Server OS: Windows 10
• Game version: PE/Win10 (delete as appropriate)

Plugins

• Test on a clean server without plugins: is the issue reproducible without any plugins loaded? Yes

[jasonwynn10]

It's because the player moves away from the source. It's the same in vanilla

[matcracker]

@jasonwynn10 In vanilla works fine. The chest inventory is closed correctly and the player teleported as well.

[jasonwynn10]

Oh, you didn't specify the issue

[matcracker]

Because I've already talked to dktapps about this problem. I opened it just to remind him.

[vzlomka76]

I can confirm. It can be fixed with removing code:
$this->removeAllWindows();

[matcracker]

@vzlomka76 where do you see it? 🤔

[vzlomka76]

in teleport method (in Player class)

[vzlomka76]

@matcracker I'm now talking about mcpe-1.2 branch.
In master branch you will delete this code from teleport method:
foreach($this->windowIndex as $window){ if($window === $this->inventory){ continue; } $this->removeWindow($window); }

[Muqsit]

do not do that^ it might solve your problem but will create many more.

[vzlomka76]

@Muqsit i know this, but I gave the reason for this bug

[AvivShopen]

This will work (i think)
$packet = new \pocketmine\network\mcpe\protocol\ContainerClosePacket(); $packet->windowid = 0; $player->dataPacket($packet);

[dktapps]

I cannot reproduce this bug with MCPE 1.2.0.25.

[matcracker]

This issue is referred to MCPE 1.1.5

[dktapps]

My point is that since it doesn't occur on the beta, this is more likely to be down to a quirk in the client which has been fixed in 1.2.

[dktapps]

I don't have MCPE 1.1.5, but I also cannot reproduce the bug on 1.1.4.51.

[matcracker]

I will try again... But I'm sure that this happens

[buchwasa]

I can’t reproduce this issue on 1.2 but yeah, it affects me on 1.1.