Pocketmine-mp: Update to Timings v2

[Muqsit]

Issue description

Timings v1 is no longer supported. So for now, /timings is useless.
This is what comes up.

Steps to reproduce the issue

1. Start timings. (/timings on)
2. Upload timings (/timings paste)
3. Open link.

OS and versions

• PocketMine-MP: (Doesn't matter) f2f51a8
• PHP: (Doesn't matter) 7.0.15
• Server OS: (Doesn't matter) Ubuntu 14.04
• Game version: (Doesn't matter) Win10

Crashdump, backtrace or other files

A Timings v1 link.

[dktapps]

Oh... that's not good.

[Muqsit]

Yeah. Figured it out just today.

[ghost]

Timings v1 has actually been outdated for a while now, we needed to switch over anyways. Thus, timings v2 looks cleaner and gives more visual detailed reports.

[dktapps]

yeah, and who do you think has the time for upgrading?

[robske110]

I actually don't like the way timings v2 look. Maybe we could host the old code somewhere (it's open src)

[Muqsit]

You all are just going off topic now. Your argument isn't going to solve this issue.

I think hosting Timings v1, as @robske110 said, might be a good idea. I too hate the new look of Timings and am better off sticking to the plain simple Timings v1.

[dktapps]

I personally like Timings V2, but the implementation looks frightful, and there's no documentation whatsoever on upgrading or implementing it.

[Muqsit]

I might kinda agree on that. https://github.com/aikar/timings/issues/16

I think the project, at this point, is just trying to promote "Paper".

[MrPowerGamerBR]

@Muqsit I think that, if you ask aikar, he will explain how to implement it. (Paper isn't the only Timings v2 implementation as far as I know, Sponge and Nukkit also has a Timings v2 implementation... but of course, those two are in Java, so that's why it was easy to implement Timings v2 on them)

And don't forget to ask aikar to create a user agent for PocketMine-MP (you can also use Sponge as the user agent... but that's just a small workaround)

For a short term fix, couldn't the timings URL be changed to the one used by Spigot?

[Muqsit]

@MrPowerGamerBR Java to PHP isn't a big deal. Anyways, if aikar has the time to help us, why doesn't he rather document Timings' API usage?
Also, it isn't as easy as changing the URL :/

[xZeroMCPE]

@Muqsit @dktapps Yes, indeed. The old Timings was way better, I myself, was able to apprehend clearly.. But the V2 seems confusing...

Well, In other word, I've created a fork of the old aikar (V1) and hosted it.

MCPETimings.com

You can start using it right-away just by chaging the url
Pardon me if this feels like i'm advertising, I just want other MCPE: Server owners to get the old timings V1 back..

[ghost]

@zhuowei

The old Timings was way better

Wrong. Timingsv2 can identify problems far beyond timingsV1.

Pardon me if this feels like i'm advertising, I just want other MCPE: Server owners to get the old timings V1 back..

You fit in the definition of advertising a crap ~fork~ ~spoon~ noob type software.

I don't like the menu on MCPE 0.15+, how about we create a new community and go back down to MCPE 0.10.5?

[Muqsit]

@madecode15 It is a temporary solution until someone figures out how the Timings v2 API works.

[Matthww]

Well mcpetimings.com is down...

[HimbeersaftLP]

I hope this doesn't count as advertising, cause I just want to help: timings.imgcl.co

[dktapps]

If you've updated your pocketmine.yml recently, you'll find an option to choose your host to use for timings. (In case anybody didn't know)

[HimbeersaftLP]

If you've updated your pocketmine.yml recently, you'll find an option to choose your host to use for timings. (In case anybody didn't know)

That's why I posted that URL :P

[dktapps]

yeah... some people have been hardcoding it though.

[Matthww]

I'm using ImagicalMines timings for some time now. Just wanted to mention it

[dktapps]

Reducing priority on this since we now have our own timings host (https://timings.pmmp.io) so this isn't a major issue anymore.

[Driesboy]

nope i like the old more

[TheDiamondYT1]

@Driesboy The old one is plain and ugly, and doesn't give much information

[dktapps]

I have no intention to fill this issue for reasons discussed elsewhere (no reference implementation, no specification, little benefit to doing so as opposed to just using a normal profiler format), so I'm going to close this issue. Timings v2 has terrible support and the work needed to implement it, without any spec or reference, is not worth the benefits.

This does not mean that timings won't be improved in the future - I do have plans to improve our fork of Timings v1 and Timings in general, but I have no intention whatsoever to implement v2.

TL;DR: Timings v2 sucks.