Pocketmine-mp: Misuse of Entity->kill() vs Entity->close() cause crashes

[dktapps]

A crash may occur when an arrow despawns due to the use of kill(). This is due to the deadTicks timeout to allow entity death animations to be shown, arrows will be updated 10x after dying, and will repeatedly call kill() on themselves until that 10 ticks is done. deadTicks should not be hardcoded to 10, and arrows should be using close() since they _despawn_, not die.

Steps to reproduce

Shoot an arrow, wait for it to despawn

[dktapps]

There is also a bad lack of documentation of Entity API methods.

[Guillaume351]

I have addParticle on a null when I throw arrows out of client sight (so when they are unloaded ?), is it linked to this ?

[dktapps]

@Guillaume351 very likely, yes. I saw several issues like this.