Pnp-modern-search: Installation doc inconsistency

Created on 5 Feb 2021  路  5Comments  路  Source: microsoft-search/pnp-modern-search

Version used
Ex: 4

Describe the bug
I wanted to make some updates to the Installation doc, at first just to fix a couple spelling things. But when I clicked the pencil to edit, it looks like the Github version is out of sync with the published version.

Can you let me know if it makes sense for me to edit the Github version or not?

Additional context
As I'm going through the installation instructions, I think it makes sense to explain how to approve the permissions a bit better, too. I'm happy to make those edits as well, but I want to be sure I'm editing the right thing.

All 5 comments

@sympmarc target the dev branch for doc updates. And if you are updating can you reference https://docs.microsoft.com/en-us/sharepoint/dev/spfx/library-component-overview and say that ext lib can be installed in a site app catalog, but has to check off "all sites" (which in itself is such a weird setup, and you can only deploy a lib once in the tenant.. weird)

Well, note that the pencil on the existing pages sends you to the main branch. Confusing!

@sympmarc hardcore people clone the repo and push for a PR 馃槈 but yes, I totally get that. We typically update main before each release.

Of course. But if you have that pencil there...

Just change the pencils to point to the dev branch, then.

Hi @sympmarc , I fixed the edit URL to redirect to the develop branch. You can now submit a PR :)

Was this page helpful?
0 / 5 - 0 ratings