Pm2: network latency metric - ping against google DNS is high

[Unitech]

2000ms
https://github.com/Unitech/pm2/blob/master/lib/Sysinfo/SystemInfo.js#L466

[tizzyapunkt]

When you look at the captures, you can see that it pings google like 10 times a second which is kinda high :)

staging1-pings.pcap.zip

Here is the report dump

--- PM2 report ----------------------------------------------------------------
Date                 : Tue Oct 15 2019 13:49:53 GMT+0200 (CEST)
===============================================================================
--- Daemon -------------------------------------------------
pm2d version         : 4.0.2
node version         : 10.3.0
node path            : /data/nvm/.nvm/versions/node/v10.3.0/bin/pm2
argv                 : /data/nvm/.nvm/versions/node/v10.3.0/bin/node,/data/nvm/.nvm/versions/node/v10.3.0/lib/node_modules/pm2/lib/Daemon.js
argv0                : node
user                 : nvm
uid                  : 2000
gid                  : 2000
uptime               : 161min
===============================================================================
--- CLI ----------------------------------------------------
local pm2            : 4.0.2
node version         : 10.3.0
node path            : /data/nvm/.nvm/versions/node/v10.3.0/bin/pm2
argv                 : /data/nvm/.nvm/versions/node/v10.3.0/bin/node,/data/nvm/.nvm/versions/node/v10.3.0/bin/pm2,report
argv0                : node
user                 : nvm
uid                  : 2000
gid                  : 2000
===============================================================================
--- System info --------------------------------------------
arch                 : x64
platform             : freebsd
type                 : FreeBSD
cpus                 : Intel(R) Xeon(R) CPU E5-2630 v3 @ 2.40GHz
cpus nb              : 2
freemem              : 684703744
totalmem             : 4254642176
home                 : /data/nvm
===============================================================================
--- PM2 list -----------------------------------------------
┌────┬─────────────────────────┬─────────┬─────────┬──────────┬────────┬──────┬──────────┬──────────┬──────────┬──────────┬──────────┐
│ id │ name                    │ version │ mode    │ pid      │ uptime │ ↺    │ status   │ cpu      │ mem      │ user     │ watching │
└────┴─────────────────────────┴─────────┴─────────┴──────────┴────────┴──────┴──────────┴──────────┴──────────┴──────────┴──────────┘
Module
┌────┬───────────────────────────────────────┬────────────────────┬───────┬──────────┬──────┬──────────┬──────────┬──────────┐
│ id │ module                                │ version            │ pid   │ status   │ ↺    │ cpu      │ mem      │ user     │
├────┼───────────────────────────────────────┼────────────────────┼───────┼──────────┼──────┼──────────┼──────────┼──────────┤
│ 1  │ pm2-logrotate                         │ 2.6.0              │ 84782 │ online   │ 0    │ 0%       │ 53.7mb   │ nvm      │
└────┴───────────────────────────────────────┴────────────────────┴───────┴──────────┴──────┴──────────┴──────────┴──────────┘
===============================================================================
--- Daemon logs --------------------------------------------
/data/nvm/.pm2/pm2.log last 20 lines:
PM2        |     at maybeClose (internal/child_process.js:961:16)
PM2        |     at Socket.stream.socket.on (internal/child_process.js:380:11)
PM2        |     at Socket.emit (events.js:182:13)
PM2        |     at Pipe._handle.close [as _onclose] (net.js:596:12)
PM2        | 2019-10-15T13:49:53: PM2 log: systeminfos collection process offline with code 1
PM2        | /data/nvm/.nvm/versions/node/v10.3.0/lib/node_modules/pm2/node_modules/systeminformation/lib/network.js:807
PM2        |                 let proc = line[6].split('/');
PM2        |                                    ^
PM2        | 
PM2        | TypeError: Cannot read property 'split' of undefined
PM2        |     at /data/nvm/.nvm/versions/node/v10.3.0/lib/node_modules/pm2/node_modules/systeminformation/lib/network.js:807:36
PM2        |     at Array.forEach (<anonymous>)
PM2        |     at /data/nvm/.nvm/versions/node/v10.3.0/lib/node_modules/pm2/node_modules/systeminformation/lib/network.js:786:19
PM2        |     at ChildProcess.exithandler (child_process.js:282:7)
PM2        |     at ChildProcess.emit (events.js:182:13)
PM2        |     at maybeClose (internal/child_process.js:961:16)
PM2        |     at Socket.stream.socket.on (internal/child_process.js:380:11)
PM2        |     at Socket.emit (events.js:182:13)
PM2        |     at Pipe._handle.close [as _onclose] (net.js:596:12)
PM2        | 2019-10-15T13:49:53: PM2 log: systeminfos collection process offline with code 1

As I can see, there is something happening in the network module, maybe its related to that?

[Unitech]

published on 4.1.2

[Unitech]

and btw interesting to see the PM2 log report, it seems that there is an issue with the network and systeminformation. PM2 might repop the external process multiple time, increasing the number of network check towards google. I've disabled the system metrics collector for now anyway in every version while we figure out a hardened solution
cc @sebhildebrandt

[sebhildebrandt]

Started to investigate this (on systeminformation side)...

[sebhildebrandt]

fixed issue causing crash in network.js in dependency package systeminformation (v4.14.13 should contain the fix).

[Unitech]

Great!

[sebhildebrandt]

@Unitech please let me know, if I also should have a look on the measurement of internet latency against google DNS or is the problem described not directly related to systeminformation.