Plyr: Uncaught RangeError: Maximum call stack size exceeded

Created on 27 Nov 2019  路  7Comments  路  Source: sampotts/plyr

Exception happens on load on latest Plyr 3.5.6, on Chrome 78, Android 8 device.

src/js/utils/is.js
const isNumber = input => getConstructor(input) === Number && !Number.isNaN(input);
src/js/utils/time.js
if (!is.number(time)) { ...

grabilla em9460
grabilla em4420

Can't replicate

Most helpful comment

Fixed in v3.5.7. Feel free to check other places if you have time... this is an _open source_, not a commercial project.

All 7 comments

Same error also in formatTime(null, displayHours, inverted) (on Safari iOS 13.2)
grabilla g16832

Try Using Chrome.... @laukstein

@AMC12010 see my above message:

Exception happens on load on latest Plyr 3.5.6, on Chrome 78, Android 8 device.

I can't replicate this on iOS 13.3 - any help appreciated on how I can replicate so I can fix. I'm a little lost.

@sampotts maybe try on BrowserStack.
Here I just create you pull request for this issue fix https://github.com/sampotts/plyr/pull/1655 (I haven't tested it, but I think it is the right fix).

The issue was that formatTime was running itself creating infinite loop. null is considered as a value and wouldn't use arguments placeholder.
See your issue
grabilla g22204

See how it should be
grabilla g20272

BTW please check if you don't have this bug also in other places.

Fixed in v3.5.7. Feel free to check other places if you have time... this is an _open source_, not a commercial project.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Zsavajji picture Zsavajji  路  3Comments

muuvmuuv picture muuvmuuv  路  3Comments

Skwai picture Skwai  路  4Comments

jwjcmw picture jwjcmw  路  4Comments

nam-co picture nam-co  路  4Comments