Plyr: Standard Volume Unit

Created on 20 Oct 2016  路  5Comments  路  Source: sampotts/plyr

Hello,
The instance.getVolume() method return value between 0 and 1. instance.setVolume(vol) need a value between 0 and 10. Why it is not the same volume unit ?

Bug

Most helpful comment

It's already in v3 which I should have out soon (sorry, I keep saying that)

All 5 comments

Good point. I'll fix this in the next major release (soon) with a few other new features as it would be a breaking change.

I'd suggest unifiying both to a range of 0 - 1 and make the volume slider accept floating point values. If a value > 1 is encountered on setVolume, you can divide by 10 for some backwards compatibilty, if needed.

I just discovered this discrepancy too. Looks like it's been in the pipe awhile. Any idea when it will land?

It's already in v3 which I should have out soon (sorry, I keep saying that)

Closing this one as I think it's fixed but feel free to re-open if not solved in v3 馃憤

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Lycanthrope picture Lycanthrope  路  4Comments

Zsavajji picture Zsavajji  路  3Comments

frumbert picture frumbert  路  3Comments

sparkktv picture sparkktv  路  4Comments

Skwai picture Skwai  路  4Comments