Plyr: Dependency on core-js@3 breaks Nuxt build

Created on 15 Apr 2019  路  3Comments  路  Source: sampotts/plyr

Hi, as title says, i cannot upgrade plyr to 3.5.3 in my nuxt project because of the updated core-js dependency. Nuxt decided to stick to core-js@2 (https://github.com/nuxt/nuxt.js/issues/5313) and updating plyr breaks the build.
Are there any real advantages in moving to core-js@3?

Most helpful comment

@Zsavajji Thanks for using Nuxt.js.

Nuxt.js has provided a way to use core-js@3 since 2.6.0 as release notes described.

But one thing needs to be notified is that you need to make sure that all of your dependencies have upgraded to core-js@3 like plyr, because if core-js@2 and core-js@3 are both used, it may lead to unexpected error due to uncertain core-js version in your node_modules which are hoisted by npm/yarn.

All 3 comments

Yep, there from what I can see... https://github.com/zloirock/core-js/blob/master/docs/2019-03-19-core-js-3-babel-and-a-look-into-the-future.md

Can't you fix the version in your package.json in resolutions ?

@Zsavajji Thanks for using Nuxt.js.

Nuxt.js has provided a way to use core-js@3 since 2.6.0 as release notes described.

But one thing needs to be notified is that you need to make sure that all of your dependencies have upgraded to core-js@3 like plyr, because if core-js@2 and core-js@3 are both used, it may lead to unexpected error due to uncertain core-js version in your node_modules which are hoisted by npm/yarn.

Just out of interest, why is plyr shipped with core-js as a dependancy? If all the js files are bundled before the package is published whats the need for the polyfills and core-js in the deps and not devDeps?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Antonio-Laguna picture Antonio-Laguna  路  3Comments

jacksonit picture jacksonit  路  4Comments

jwjcmw picture jwjcmw  路  4Comments

nam-co picture nam-co  路  4Comments

TheZoker picture TheZoker  路  4Comments