Plugin-php: Prettier added useless parenthese

[mathieutu]

-        return static::class . '@' . $method;
+        return (static::class . '@' . $method);

[mathieutu]

Idem :

-        return [
+        return (
+            [
                 'email' => 'required|string|email|max:255|unique:users',
                 'password' => 'required|string|min:6|confirmed',
-            ] + self::profilesRules();
+            ] + self::profilesRules()
+        );

[alexander-akait]

@mathieutu return always avoid parens when expression is in one line and add parens when expression is multiline

[alexander-akait]

@mathieutu

return (static::class . '@' . $method);

look as bug.

Second example expected.

[mathieutu]

Idem here:

-        return $this->customer->paymentService ?? null;
+        return ($this->customer->paymentService ?? null);

Imo in php, we should not add parentheses in any return cases. (Never seen that in any php code)

[alexander-akait]

@mathieutu already fixed in master, here you examples https://github.com/prettier/plugin-php/pull/612, it is expected right?

[alexander-akait]

@mathieutu

Imo in php, we should not add parentheses in any return cases. (Never seen that in any php code)

Disagree. return have same logic in js and php. Why we should avoid parens?

[Meroje]

Why we should avoid parens?

Because there is not a single person anywhere doing it ?

[alexander-akait]

@Meroje please create issue in prettier about this, we use logic from prettier.

[alexander-akait]

/cc @vjeux can you describe why we need parens for return, thanks

[vjeux]

In JavaScript, there’s a “feature” called automatic semi-colon insertion that makes the following

return
  123

be parsed as

return;
123;

So you have to have parenthesis if you want to make it multiline otherwise you return undefined.

return (
  123
);

Because of this, people in js tend to put parenthesis in a lot more places than php and put { on the same line.

[mathieutu]

Thanks for the explanation @vjeux! 🙂
So we know now that it's only linked to a js context, so it's the plugin responsibility to choose if it's kept or not.

[alexander-akait]

@mathieutu feel free to send a PR

[czosel]

:+1: Let's remove the braces in the PHP plugin then!

[mathieutu]

ok thanks!
As I haven't contributed yet to prettier, I don't really know how it works under the hood, and how to make that done.

I'll try to check that when it'll be quieter at work.

[mathieutu]

Thank you @evilebottnawi! 🎉
After having seen your PR, I can confirm that I wasn't capable to do it right now!

[alexander-akait]

@mathieutu don't worry, prettier is very easy tool, feel free to contribute