Plugin-php: Indent complex conditions

[czosel]

Input:

                        if (
                            $showNoticeValue === '1' &&
                            !is_null($currentService) &&
                            $currentService->getServiceId() === $activation->getServiceId()
                        ) {

Output:

                        if (
                            $showNoticeValue === '1' &&
                            !is_null($currentService) &&
                            $currentService->getServiceId() ===
                            $activation->getServiceId()
                        ) {

I'd suggest

                        if (
                            $showNoticeValue === '1' &&
                            !is_null($currentService) &&
                            $currentService->getServiceId() ===
                                $activation->getServiceId()
                        ) {

[alexander-akait]

/cc @mgrip i think we should fix this next :smile: Maybe use copy/past logic from prettier and adapt for php

[mgrip]

sounds good 👍 i can try to take a look later today. might see if i can rope in https://github.com/prettier/plugin-php/issues/375 as well

[mgrip]

interestingly enough, prettierjs actually prints w/o the indentation

There were a whole bunch of other cases that get addressed in #400 though

[czosel]

It actually does indent once you reach the line limit (see here).

My example above is indented deeply because i copied it out of some existing file including indentation.

[mgrip]

Ah got it, that makes sense - let me add a test to that PR to make sure the same happens in ours

[mgrip]

yup, all set 👍