Plots2: Brainstorm a list of critical full-stack system tests we should add

[jywarren]

Once https://github.com/publiclab/plots2/pull/4888 is merged (done!), we'll have system tests running in Travis! This means we can test a full running application on each PR, including javascript, ruby, and everything. We've had some recurring and difficult-to-test issues come up over the past few years, and this is a chance to monitor those delicate and highly integrated scenarios with tests!

Here's our initial test, which is passing, using documentation from https://guides.rubyonrails.org/testing.html#implementing-a-system-test :

https://github.com/publiclab/plots2/blob/e8cfcd442a640151eea2faf1d39ce9f5e968b95e/test/system/search_test.rb#L1-L13

Based on this template, we can do things like interact with Javascript-driven features, click on things, etc. Let's brainstorm a list of the most critical things we should protect first with this powerful new testing system!

• [x] the basic login sequence -- ensuring that the login modal appears, accepts inputs, and logs us in #5682
• [x] posting a new note #5605
• [x] loading the dashboard #5682
• [x] using typeahead search in the navbar #5525
• [x] using /search #4888
• [x] signup https://github.com/publiclab/plots2/blob/25d7e11f4b8f5e4eca5aef2bd596e84dedfdc5d3/test/system/screenshots_test.rb#L18
• [x] commenting on a post #7255
• [x] uploading an image to a comment: https://github.com/publiclab/plots2/pull/5526
• [x] drag-to-upload an image in a comment https://github.com/publiclab/plots2/pull/5655
• [x] editing a wiki #7270
• [x] uploading an image to a wiki: https://github.com/publiclab/plots2/issues/5650 #7270
• [x] adding a tag https://github.com/publiclab/plots2/issues/5316
• [x] liking #7252

What else has broken recently?

(Note: there is also a means for system tests to take screenshots and upload them as 'artifacts' in Travis... 😮 📸 so if anyone wants to try opening a PR for that we'd love to see it tried out - but maybe best open a new issue for it! -- update: testing here: https://github.com/publiclab/plots2/pull/5320)

[grvsachdeva]

This seems awesome @jywarren! I will go through the ruby on rails guide first as I haven't written any system test till now :see_no_evil:

[jywarren]

😄

Example test:

require 'application_system_test_case'

class Users::CreateTest < ApplicationSystemTestCase
  test "adding a new user" do
    visit users_path
    click_on 'New User'

    fill_in 'Name', with: 'Arya'
    click_on 'Create User'

    assert_text 'Arya'
  end
end

[GettyOrawo]

Nice :small_airplane: So every test will have it's own test file under plots2/test/system/ ?

[jywarren]

Hi, @GettyOrawo -- i think we can put multiple tests in each file!

[jywarren]

Also, i believe it's possible to use anything from Capybara's DSL (domain specific language?) -- https://github.com/teamcapybara/capybara#the-dsl

It mentions attaching files: https://github.com/teamcapybara/capybara#interacting-with-forms

attach_file('Image', '/path/to/image.jpg')

And evaluating javascript functions: https://github.com/teamcapybara/capybara#scripting

result = page.evaluate_script('4 + 4');

I'm not /sure/ these will work, but for testing things like image upload, I'd love to try it!

[jywarren]

Attempted to use a JS function in https://github.com/publiclab/plots2/pull/5525!

[jywarren]

And tried using attach_file here to test comment image upload! https://github.com/publiclab/plots2/pull/5526

[jywarren]

I found this great Capybara cheatsheet!!! https://gist.github.com/zhengjia/428105

[jywarren]

And, I seem to see a chrome plugin that can generate -- even "record" capybara tests based on your interactions!

https://github.com/polarblau/capycorder/

We could use this to quickly generate tests.

[namangupta01]

This seems interesting, I also want to contribute on this one.

[jywarren]

OK! With help from Capycorder, I completed a system test of posting at /post -- it's really cool, and goes through the steps of:

1. logging in
2. filling out the posting form
3. pressing Publish
4. confirming that the page now shows the post

See it here:

https://github.com/publiclab/plots2/blob/e190eae1ce7bf215b99b6efe7f828e17deb3213e/test/system/post_test.rb#L10-L34

We can use this as an example to make more system tests, like for #5526

[jywarren]

Noting this for some AJAX methods: https://stackoverflow.com/questions/36536111/waiting-for-ajax-with-capybara-poltergeist

[jywarren]

also

within('comment-form') do

end

[jywarren]

Noting this would be a good feature to fix and then protect with a system test! https://github.com/publiclab/plots2/issues/768

[jywarren]

We now have screenshots generating in system tests!!!! And pasting into PR comments: https://github.com/publiclab/plots2/pull/5868

[SidharthBansal]

@Uzay-G @VladimirMikulic i think you both will be willing to complete this issue together.
I can mentor this if you both are willing.
We can brainstorm about points after merging prs too. This will be of a lot of points for sure.

[Uzay-G]

Oh wow I am so excited about this! This issue seems really fun to work on! :+1:

[Uzay-G]

@SidharthBansal I am going get started with some signup and login tests

[SidharthBansal]

@Uzay-G I can't allow you to work on this before you finish with login work.
As GCI says one issue at a time. You are assigned open Id work right now.
I hope you will understand. Try to finish that up asap so that you can
start working on system tests.

On Wed, 15 Jan 2020, 10:23 pm Uzay-G, [e-mail] wrote:

Oh wow I am so excited about this! This issue seems really fun to work on!
👍

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQYWYGBEVFUU3G3XCZTQ545SPA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBALBY#issuecomment-574752135,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ5TFRSQXMJIUJFQOI3Q545SPANCNFSM4HCQK2AQ
.

[VladimirMikulic]

With @Uzay-G? It would be my pleasure.

[SidharthBansal]

Let's discuss login related work on their respective issues. Don't mix up
things.

On Wed, 15 Jan 2020, 10:26 pm Uzay-G, [e-mail] wrote:

@SidharthBansal https://github.com/SidharthBansal I am going get
started some signup and login tests

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQYI7BGZRTWUF57AJ2LQ5452JA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBAR5I#issuecomment-574753013,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQZ5A3VW6VU43BGP7U3Q5452JANCNFSM4HCQK2AQ
.

[VladimirMikulic]

@SidharthBansal thank you for giving us a chance and recognizing our work :+1:

[Uzay-G]

@Uzay-G I can't allow you to work on this before you finish with login work. As GCI says one issue at a time. You are assigned open Id work right now. I hope you will understand. Try to finish that up asap so that you can start working on system tests.
…
On Wed, 15 Jan 2020, 10:23 pm Uzay-G, @.*> wrote: Oh wow I am so excited about this! This issue seems really fun to work on! +1 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5316?email_source=notifications&email_token=AFAAEQYWYGBEVFUU3G3XCZTQ545SPA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBALBY#issuecomment-574752135>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAAEQ5TFRSQXMJIUJFQOI3Q545SPANCNFSM4HCQK2AQ .

Oh yeah I totally understand. The open_id tests are a bit confusing for me but I will try :+1:

[VladimirMikulic]

@SidharthBansal are these issues going to be published on GCI dashboard or we comment here to claim them? Thanks.

[SidharthBansal]

I mean there will be a lot of system tests for a lot of features of public
lab. So you both can divide parts. like stick to two parts first say
comments and tag. Suppose uzay picked comments and you picked tags. Then
you both can chat on prs and review each other's prs. Once both prs are
ready I can review them and merge them together. Other folks can also join
in this fashion with you two.
This will help me in reviewing the prs. As only one portion of public lab
is being tested through system tests your work load will be lesser too.
Most importantly you both will become friends. May be you will get more
friends to help you write tests

We can decide about points after merging prs. Believe me there will be a
lot of tests for each feature.
We should target login tests first as they are in progress by you both.
What do you think?
Any ideas?

On Wed, 15 Jan 2020, 10:26 pm Vladimir Mikulic, [e-mail]
wrote:

With @Uzay-G https://github.com/Uzay-G? It would be my pleasure.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQYH64346UCSK3O3CZLQ5454HA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBAT3Y#issuecomment-574753263,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ22XKFWOENQCSXBNKDQ5454HANCNFSM4HCQK2AQ
.

[SidharthBansal]

Please take help from other people too. I am having fever so reviewing
things lately. Sorry for inconvenience held

On Wed, 15 Jan 2020, 10:28 pm Uzay-G, [e-mail] wrote:

@Uzay-G https://github.com/Uzay-G I can't allow you to work on this
before you finish with login work. As GCI says one issue at a time. You are
assigned open Id work right now. I hope you will understand. Try to finish
that up asap so that you can start working on system tests.
… <#m_7975471188190812929_>
On Wed, 15 Jan 2020, 10:23 pm Uzay-G, @.*> wrote: Oh wow I am so
excited about this! This issue seems really fun to work on! +1 — You are
receiving this because you commented. Reply to this email directly, view it
on GitHub <#5316 https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQYWYGBEVFUU3G3XCZTQ545SPA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBALBY#issuecomment-574752135>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ5TFRSQXMJIUJFQOI3Q545SPANCNFSM4HCQK2AQ
.

Oh yeah I totally understand. The open_id tests are a bit confusing for
me but I will try 👍

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQZ7U2PLNRTYJDSDVXTQ546EFA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBA3SQ#issuecomment-574754250,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQYH6JQYAY7EDAWAXMLQ546EFANCNFSM4HCQK2AQ
.

[SidharthBansal]

I am thinking of publishing it after changes are merged. Maybe we can have
a hof for three sections comments, tags and login tests. This will reduce
overhead time to get your tasks approved. Similarly for all other
candidates.
Policies are same for each candidate. I treat all gci students equally.
Rest everything depends on fortune and hardwork.

On Wed, 15 Jan 2020, 10:32 pm Vladimir Mikulic, [e-mail]
wrote:

@SidharthBansal https://github.com/SidharthBansal are these issues
going to be published on GCI dashboard or we comment here to claim them?
Thanks.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQYMJS2UTEVXSQRZKPTQ546SJA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBBIVA#issuecomment-574755924,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ5IV2CIE4WTMHDIWITQ546SJANCNFSM4HCQK2AQ
.

[VladimirMikulic]

@SidharthBansal take care of yourself, the health is the most important.
I've added 2 signup tests, I think that's taken care of.

[SidharthBansal]

I just want to reduce the overhead so I wrote it in the welcoming issue.

On Wed, 15 Jan 2020, 10:34 pm Sidharth Bansal, <
[email protected]> wrote:

I am thinking of publishing it after changes are merged. Maybe we can have
a hof for three sections comments, tags and login tests. This will reduce
overhead time to get your tasks approved. Similarly for all other
candidates.
Policies are same for each candidate. I treat all gci students equally.
Rest everything depends on fortune and hardwork.

On Wed, 15 Jan 2020, 10:32 pm Vladimir Mikulic, [e-mail]
wrote:

@SidharthBansal https://github.com/SidharthBansal are these issues
going to be published on GCI dashboard or we comment here to claim them?
Thanks.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQYMJS2UTEVXSQRZKPTQ546SJA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBBIVA#issuecomment-574755924,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ5IV2CIE4WTMHDIWITQ546SJANCNFSM4HCQK2AQ
.

[VladimirMikulic]

That's a good idea to reduce overhead.

[Uzay-G]

I mean there will be a lot of system tests for a lot of features of public lab. So you both can divide parts. like stick to two parts first say comments and tag. Suppose uzay picked comments and you picked tags. Then you both can chat on prs and review each other's prs. Once both prs are ready I can review them and merge them together. Other folks can also join in this fashion with you two. This will help me in reviewing the prs. As only one portion of public lab is being tested through system tests your work load will be lesser too. Most importantly you both will become friends. May be you will get more friends to help you write tests We can decide about points after merging prs. Believe me there will be a lot of tests for each feature. We should target login tests first as they are in progress by you both. What do you think? Any ideas?
…
On Wed, 15 Jan 2020, 10:26 pm Vladimir Mikulic, @.*> wrote: With @Uzay-G https://github.com/Uzay-G? It would be my pleasure. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5316?email_source=notifications&email_token=AFAAEQYH64346UCSK3O3CZLQ5454HA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBAT3Y#issuecomment-574753263>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAAEQ22XKFWOENQCSXBNKDQ5454HANCNFSM4HCQK2AQ .

I think this is a great idea! I am excited to work on this with @VladimirMikulic after I finish my task.

[VladimirMikulic]

I am looking forward to our cooperation @Uzay-G :rocket:

[SidharthBansal]

I will request you both to complete the login things together by today or
tomorrow. Then we can drive here with other folks.
This gci will be bigger than gsoc for you guys. I hope you are learning a
little from me. :-)

On Wed, 15 Jan 2020, 10:37 pm Vladimir Mikulic, [e-mail]
wrote:

I am looking forward to our cooperation @Uzay-G
https://github.com/Uzay-G 🚀

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQ27LLOHNKQJMF2KNL3Q547DJA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBBYNI#issuecomment-574757941,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ2TXHO52XCKSVMZZZLQ547DJANCNFSM4HCQK2AQ
.

[SidharthBansal]

https://codein.withgoogle.com/dashboard/tasks/6015285472002048/
Here is the task

On Wed, 15 Jan 2020, 10:48 pm Sidharth Bansal, <
[email protected]> wrote:

I will request you both to complete the login things together by today or
tomorrow. Then we can drive here with other folks.
This gci will be bigger than gsoc for you guys. I hope you are learning a
little from me. :-)

On Wed, 15 Jan 2020, 10:37 pm Vladimir Mikulic, [e-mail]
wrote:

I am looking forward to our cooperation @Uzay-G
https://github.com/Uzay-G 🚀

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQ27LLOHNKQJMF2KNL3Q547DJA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBBYNI#issuecomment-574757941,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ2TXHO52XCKSVMZZZLQ547DJANCNFSM4HCQK2AQ
.

[Uzay-G]

I will request you both to complete the login things together by today or tomorrow. Then we can drive here with other folks. This gci will be bigger than gsoc for you guys. I hope you are learning a little from me. :-)
…
On Wed, 15 Jan 2020, 10:37 pm Vladimir Mikulic, @.*> wrote: I am looking forward to our cooperation @Uzay-G https://github.com/Uzay-G rocket — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5316?email_source=notifications&email_token=AFAAEQ27LLOHNKQJMF2KNL3Q547DJA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBBYNI#issuecomment-574757941>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAAEQ2TXHO52XCKSVMZZZLQ547DJANCNFSM4HCQK2AQ .

Yeah we really are learning a lot :+1:.

[VladimirMikulic]

@SidharthBansal we are learning a lot and indeed this is bigger than GSoC. Lots of breaking changes. @Uzay-G let's make this GCI memorable.

[Uzay-G]

I agree. Let's do this! :+1:

[SidharthBansal]

It will be great to get this thing done asap. May be we will have add more
issues soon to gci like this one. But let's complete this.
Sorry for adding this so late.
I intentionally dint add this up. If I added this in the beginning then you
will find it very difficult. Now it is really easy for you to complete it.
Remember to do things in collaboration. Open source is collaboration and
team work nothing else.

On Wed, 15 Jan 2020, 10:53 pm Uzay-G, [e-mail] wrote:

I agree. Let's do this! 👍

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQYBKWFUDURLZKO5QG3Q55BB3A5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBDQSQ#issuecomment-574765130,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQYXD3MV7TBMGCFIGO3Q55BB3ANCNFSM4HCQK2AQ
.

[Uzay-G]

I am getting started on testing signup. Just having problems with the spam-blocker..

[VladimirMikulic]

@Uzay-G I've implemented the signup tests, I don't know if they are enough though.

[Uzay-G]

Oh alright, I am just curious, how did you pass spam detection?

[VladimirMikulic]

@Uzay-G I did not. I was just testing correct error messages.

[Uzay-G]

Oh alright, you mean the validation pr you did earlier? Yeah no I am trying to test signing up a user.

[VladimirMikulic]

Take a look at test/integration/signup_flow_test.rb.

[VladimirMikulic]

They put @spamaway parameter, that's how they bypass it.

[SidharthBansal]

Can you please open up an issue for signup tests and discuss things there?

On Thu, Jan 16, 2020 at 12:28 AM Vladimir Mikulic [e-mail]
wrote:

The put @spamaway parameter, that's how they bypass it.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQ5RLG62AII3XPJ7KZLQ55MFFA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBMTEQ#issuecomment-574802322,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQYVZOZDFSGD6DN3BRTQ55MFFANCNFSM4HCQK2AQ
.

[SidharthBansal]

Similarly for other feature system tests like comments, tags, stats, etc

On Thu, Jan 16, 2020 at 12:42 AM Sidharth Bansal <
[email protected]> wrote:

Can you please open up an issue for signup tests and discuss things there?

On Thu, Jan 16, 2020 at 12:28 AM Vladimir Mikulic <
[email protected]> wrote:

The put @spamaway parameter, that's how they bypass it.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQ5RLG62AII3XPJ7KZLQ55MFFA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBMTEQ#issuecomment-574802322,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQYVZOZDFSGD6DN3BRTQ55MFFANCNFSM4HCQK2AQ
.

[VladimirMikulic]

@Uzay-G let's move the discussion on Gitter.

[Uzay-G]

Yeah alright :+1:

[VladimirMikulic]

@SidharthBansal should we repair @jywarren's tests or? Thanks.

[jywarren]

@VladimirMikulic which ones, sorry this is a long convo! I'd love help finishing the ones I tried to start, i got really stuck! 🙌 ❤️

[VladimirMikulic]

@jywarren No problem we'll finish all of them!

[SidharthBansal]

That's the spirit.

On Thu, 16 Jan 2020, 5:33 am Vladimir Mikulic, [e-mail]
wrote:

No problem we'll finish all of them!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQ3TK4WEKV3TAQUBXDTQ56P5FA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJCIDNQ#issuecomment-574914998,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQZL6EBM2Z3D23KT6MTQ56P5FANCNFSM4HCQK2AQ
.

[jywarren]

Hi folks, i love all the system tests. Here's one that would help with dependabot! We often get upgrades for these that we can't evaluate from tests, so we have to try them out manually:

• jquery-file-upload: https://github.com/publiclab/plots2/pull/7063
• blueimp-file-upload: https://github.com/publiclab/plots2/pull/7059
• jsdiff https://github.com/publiclab/plots2/pull/7131

I wonder if the new comment image drag test covers the first two -- and if we could do a similar image drag test for the /post editor, and the /wiki/new editor, and then be much more confident about merging those dependabot updates?

You're on a tear, folks! Great work!

[VladimirMikulic]

@jywarren I'll do the editor image upload testing :+1: No worries.

[VladimirMikulic]

@jywarren alright, I've tested it manually. You should be able to safely merge them.

[jywarren]

ok!!! Thank you!

On Thu, Jan 16, 2020 at 5:46 PM Vladimir Mikulic [e-mail]
wrote:

@jywarren https://github.com/jywarren alright, I've tested it manually.
You should be able to safely merge them.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AAAF6J5JK4OPPZB22LA4SPLQ6DPVNA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJF2JUY#issuecomment-575382739,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAF6J4SVZHT6AF4UG77PXTQ6DPVNANCNFSM4HCQK2AQ
.

[jywarren]

I think this might be complete, folks! Now thinking on the runtime issue at #7272!

[SidharthBansal]

@jywarren can we close this issue now?

[VladimirMikulic]

@SidharthBansal this is not complete yet. The signup system test is missing. (We only have the 2 tests that cover form validation messages)

[SidharthBansal]

Oh, please tell the pr number so that I can review and quickly merge

On Fri, Jan 17, 2020 at 11:25 AM Vladimir Mikulic [e-mail]
wrote:

@SidharthBansal https://github.com/SidharthBansal this is not complete
yet. The signup system test is missing. (We only have the 2 tests that
cover form validation messages)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQ3NXS75BUYXFJRTGN3Q6FB3LA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJGRF3Q#issuecomment-575476462,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQZESLYCHK32QWIQMZDQ6FB3LANCNFSM4HCQK2AQ
.

[VladimirMikulic]

I haven't written it yet :)

[SidharthBansal]

Oh, i thought you are quicker than me

On Fri, Jan 17, 2020 at 11:29 AM Vladimir Mikulic [e-mail]
wrote:

I haven't written it yet :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQ3Z7JGNASBDYRY3YF3Q6FCMBA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJGRNPA#issuecomment-575477436,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ2G5Q6NM6NDO5YEP3TQ6FCMBANCNFSM4HCQK2AQ
.

[VladimirMikulic]

I had a very busy night, but I will write them, don't worry.

[SidharthBansal]

Take rest. Take it as learning. Don't take it as a competition.

On Fri, Jan 17, 2020 at 11:39 AM Vladimir Mikulic [e-mail]
wrote:

I had a very busy night, but I will write them, don't worry.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQYMLSGO5W6MAND6ON3Q6FDSDA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJGR65Y#issuecomment-575479671,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ2K4A2IM5HAUNZ6M6DQ6FDSDANCNFSM4HCQK2AQ
.

[jywarren]

I think there is a signup test in the screenshots suite!

On Fri, Jan 17, 2020 at 1:14 AM Sidharth Bansal [e-mail]
wrote:

Take rest. Take it as learning. Don't take it as a competition.

On Fri, Jan 17, 2020 at 11:39 AM Vladimir Mikulic <
[email protected]>
wrote:

I had a very busy night, but I will write them, don't worry.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQYMLSGO5W6MAND6ON3Q6FDSDA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJGR65Y#issuecomment-575479671
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AFAAEQ2K4A2IM5HAUNZ6M6DQ6FDSDANCNFSM4HCQK2AQ

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AAAF6J4MRB2FV7L56IHPO5TQ6FEDLA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJGSHDY#issuecomment-575480719,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAF6J22MVTRMWDWFI7W3XTQ6FEDLANCNFSM4HCQK2AQ
.

[SidharthBansal]

Here are some other issues for system tests:
https://github.com/publiclab/plots2/pull/3630
https://github.com/publiclab/plots2/pull/3553

[VladimirMikulic]

@jywarren correct, we have a signup test, but it only covers the form error messages.
We need one that actually signs up the user and tests if we are on dashboard and that user is created successfully.

[SidharthBansal]

I think there is an integration test for it.

On Fri, Jan 17, 2020 at 9:33 PM Vladimir Mikulic [e-mail]
wrote:

@jywarren https://github.com/jywarren correct, we have a signup test,
but it only covers the form error messages.
We need one that actually signs up the user and tests if we are on
dashboard and that user is created successfully.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQ32AW77742MHE3A4ZDQ6HJFLA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIENNY#issuecomment-575686327,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ2ULJ4B42LZFN433ILQ6HJFLANCNFSM4HCQK2AQ
.

[SidharthBansal]

Don't write redundant tests. Please ensure COMPLETENESS and NO REDUNDANCY
amongst the tests.
Thanks

On Fri, Jan 17, 2020 at 9:48 PM Sidharth Bansal <
[email protected]> wrote:

I think there is an integration test for it.

On Fri, Jan 17, 2020 at 9:33 PM Vladimir Mikulic [e-mail]
wrote:

@jywarren https://github.com/jywarren correct, we have a signup test,
but it only covers the form error messages.
We need one that actually signs up the user and tests if we are on
dashboard and that user is created successfully.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQ32AW77742MHE3A4ZDQ6HJFLA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIENNY#issuecomment-575686327,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ2ULJ4B42LZFN433ILQ6HJFLANCNFSM4HCQK2AQ
.

[VladimirMikulic]

In that case, it's no longer required. I haven't checked the codebase yet, but there won't be redundancy @SidharthBansal :+1:

[SidharthBansal]

Please check. If no such integration test present, then write a system test
for it.
We will require system tests for linking oauth providers to the user
profile while the user is logged in.
Also we will require multi tag subscription tests.
Let's complete the tests which we know we need to do for sure before
jumping to other tests. Testing is really critical branch of Software
Engineering. I will suggest to add priority tests which you think you
should aim at first. Once you are done with all the priority tests then we
can discuss. What do you think?

On Fri, Jan 17, 2020 at 9:52 PM Vladimir Mikulic [e-mail]
wrote:

In that case, it's no longer required. I haven't checked the codebase yet,
but there won't be redundancy @SidharthBansal
https://github.com/SidharthBansal 👍

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQ2YEHRU4RAAACM3J2TQ6HLLXA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIGOCQ#issuecomment-575694602,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ6MO3D44EDOSNKBS2LQ6HLLXANCNFSM4HCQK2AQ
.

[VladimirMikulic]

It would be helpful if we could have a list like in this issue, although it's fine to tag me on every system test :)

[SidharthBansal]

You can create a list if you want. Thanks for trying to organise things

On Fri, Jan 17, 2020 at 10:03 PM Vladimir Mikulic [e-mail]
wrote:

It would be helpful if we could have a list like in this issue, although
it's fine to tag me on every system test :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQ3DINFGORMZLSMMU7TQ6HMWDA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIHSIY#issuecomment-575699235,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ753XGZX3E3CCZC3XTQ6HMWDANCNFSM4HCQK2AQ
.

[Uzay-G]

Please check. If no such integration test present, then write a system test for it. We will require system tests for linking oauth providers to the user profile while the user is logged in. Also we will require multi tag subscription tests. Let's complete the tests which we know we need to do for sure before jumping to other tests. Testing is really critical branch of Software Engineering. I will suggest to add priority tests which you think you should aim at first. Once you are done with all the priority tests then we can discuss. What do you think?
…
On Fri, Jan 17, 2020 at 9:52 PM Vladimir Mikulic @.*> wrote: In that case, it's no longer required. I haven't checked the codebase yet, but there won't be redundancy @SidharthBansal https://github.com/SidharthBansal +1 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5316?email_source=notifications&email_token=AFAAEQ2YEHRU4RAAACM3J2TQ6HLLXA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIGOCQ#issuecomment-575694602>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAAEQ6MO3D44EDOSNKBS2LQ6HLLXANCNFSM4HCQK2AQ .

Hey @SidharthBansal, I thought of making system tests for these but I'm not sure it would be useful since the system tests don't really add much to the existing tests we worked on for oauth. What do you think?

[SidharthBansal]

Which tests you wanna add?

On Fri, 17 Jan 2020, 10:55 pm Uzay-G, [e-mail] wrote:

Please check. If no such integration test present, then write a system
test for it. We will require system tests for linking oauth providers to
the user profile while the user is logged in. Also we will require multi
tag subscription tests. Let's complete the tests which we know we need to
do for sure before jumping to other tests. Testing is really critical
branch of Software Engineering. I will suggest to add priority tests which
you think you should aim at first. Once you are done with all the priority
tests then we can discuss. What do you think?
… <#m_5782174475909575622_>
On Fri, Jan 17, 2020 at 9:52 PM Vladimir Mikulic @.*> wrote: In that
case, it's no longer required. I haven't checked the codebase yet, but
there won't be redundancy @SidharthBansal
https://github.com/SidharthBansal https://github.com/SidharthBansal +1
— You are receiving this because you were mentioned. Reply to this email
directly, view it on GitHub <#5316
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQ2YEHRU4RAAACM3J2TQ6HLLXA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIGOCQ#issuecomment-575694602>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ6MO3D44EDOSNKBS2LQ6HLLXANCNFSM4HCQK2AQ
.

Hey @SidharthBansal https://github.com/SidharthBansal, I thought of
making system tests for these but I'm not sure it would be useful since
with this functionality system tests don't really add much to the existing
tests we worked on for oauth. What do you think?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQ7P4PFZICYQUM566MDQ6HSXRA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIMQCQ#issuecomment-575719434,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ3357JAPQ5TRYIFPBDQ6HSXRANCNFSM4HCQK2AQ
.

[Uzay-G]

I will work on some login tests for https://github.com/publiclab/plots2/issues/6141

[SidharthBansal]

Sure

On Fri, 17 Jan 2020, 11:00 pm Uzay-G, [e-mail] wrote:

I will work on some login tests for #6141
https://github.com/publiclab/plots2/issues/6141

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQ36WSXZP3K2XQ6M6WDQ6HTMZA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIM7HY#issuecomment-575721375,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ3LIO4ZXXDMRXQQUPDQ6HTMZANCNFSM4HCQK2AQ
.

[VladimirMikulic]

I am working on comment sanitization by the way.

[SidharthBansal]

Great thanks

On Fri, 17 Jan 2020, 11:28 pm Vladimir Mikulic, [e-mail]
wrote:

I am working on comment sanitization by the way.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQ74VAYCY4ZN7A4F5JTQ6HWVVA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIPLOI#issuecomment-575731129,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ2N5PRHKDKXD77WAWLQ6HWVVANCNFSM4HCQK2AQ
.

[jywarren]

Could we add confirmation of this function to the list of system tests we want to do? https://github.com/publiclab/plots2/issues/6926#issuecomment-562350065

[jywarren]

I think the ideal is anything which involves complex HTML/JavaScript/Ruby
interaction, so login, commenting, uploading, editor are all great... but
since they are relatively slow tests, let's be rigorous about what really
must be a system test. Thanks!!!!

On Fri, Jan 17, 2020 at 1:01 PM Sidharth Bansal [e-mail]
wrote:

Great thanks

On Fri, 17 Jan 2020, 11:28 pm Vladimir Mikulic, [e-mail]
wrote:

I am working on comment sanitization by the way.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQ74VAYCY4ZN7A4F5JTQ6HWVVA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIPLOI#issuecomment-575731129
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AFAAEQ2N5PRHKDKXD77WAWLQ6HWVVANCNFSM4HCQK2AQ

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AAAF6J6PCB6NEGUMC47RGPLQ6HXA3A5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIPTHI#issuecomment-575732125,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAF6JY5UJY4N46GTXV6GPDQ6HXA3ANCNFSM4HCQK2AQ
.

[Uzay-G]

I think the ideal is anything which involves complex HTML/JavaScript/Ruby interaction, so login, commenting, uploading, editor are all great... but since they are relatively slow tests, let's be rigorous about what really must be a system test. Thanks!!!! On Fri, Jan 17, 2020 at 1:01 PM Sidharth Bansal [e-mail] wrote:
…
Great thanks On Fri, 17 Jan 2020, 11:28 pm Vladimir Mikulic, @.*> wrote: > I am working on comment sanitization by the way. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #5316?email_source=notifications&email_token=AFAAEQ74VAYCY4ZN7A4F5JTQ6HWVVA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIPLOI#issuecomment-575731129 >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AFAAEQ2N5PRHKDKXD77WAWLQ6HWVVANCNFSM4HCQK2AQ > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5316?email_source=notifications&email_token=AAAF6J6PCB6NEGUMC47RGPLQ6HXA3A5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIPTHI#issuecomment-575732125>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6JY5UJY4N46GTXV6GPDQ6HXA3ANCNFSM4HCQK2AQ .

I am working on the login but want to make sure my tests are useful. Do you have any ideas on some very useful options for testing?

[Uzay-G]

I can't think of any more useful tests to make... @jywarren do you have any ideas on some that would be useful. I don't want to make useless tests especially since they slow down Travis considerably.

[jywarren]

Well, we had a "rich wiki editing" system, but it is itself quite buggy. I do think that possibly some system tests could help with it, though.

You get to it by clicking this button:

[jywarren]

https://github.com/publiclab/plots2/search?q=rich+wiki&type=Issues - but maybe this isn't really about system tests but about a long-broken system we want to fix!

[Uzay-G]

Nice! I am going to work on this :+1:

[SidharthBansal]

Awesome thanks for rich wiki test suggestions Jeff

On Sat, Jan 18, 2020 at 4:09 AM Uzay-G [e-mail] wrote:

Nice! I am going to work on this 👍

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQ3VIP2Q4MT4VKHFLOLQ6IXRPA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJJFWBQ#issuecomment-575822598,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQY3LVNVBY4NLKKR3WLQ6IXRPANCNFSM4HCQK2AQ
.

[sssash18]

@SidharthBansal @Uzay-G I dont think system tests for reset password in login flow exists, do you think they should be added?

[Uzay-G]

@SidharthBansal @Uzay-G I dont think system tests for reset password in login flow exists, do you think they should be added?

I thought about it but I am not sure it is possible because to reset the password an email is sent to the user. I am not sure how we could replicate that in a system test

[jywarren]

Hmm. If you look at the mailer tests we do have the ability to check the outgoing mail queue...

[Uzay-G]

Is it possible to look at the contents of the emails?

On Sat, Jan 18, 2020, 18:53 Jeffrey Warren [e-mail] wrote:

Hmm. If you look at the mailer tests we do have the ability to check the
outgoing mail queue...

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AMTREYJNEJTNZUP2H2RIRC3Q6M62BA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJJ6GGQ#issuecomment-575922970,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMTREYIE32AWDLFXS6ZTI6TQ6M62BANCNFSM4HCQK2AQ
.

[jywarren]

Yes! Take a look at this example: https://github.com/publiclab/plots2/blob/master/test/functional/admin_controller_test.rb#L472

[sssash18]

@jywarren @Uzay-G @SidharthBansal I would like to work upon the test of reset password verification

[VladimirMikulic]

@SidharthBansal @jywarren which other system tests are missing?

[SidharthBansal]

Sure Suyash. That will be great.

On Sun, Jan 19, 2020 at 11:41 AM Vladimir Mikulic [e-mail]
wrote:

@SidharthBansal https://github.com/SidharthBansal @jywarren
https://github.com/jywarren which other system tests are missing?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQ3QOJDOYNC7D6RNPC3Q6PVHZA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJKJ56I#issuecomment-575971065,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ5HSYSDRYDFK3XGPYLQ6PVHZANCNFSM4HCQK2AQ
.

[jywarren]

Anything else here? Maybe we are good?

[SidharthBansal]

I think we can close this

On Tue, 21 Jan 2020, 11:18 pm Jeffrey Warren, [e-mail]
wrote:

Reopened #5316 https://github.com/publiclab/plots2/issues/5316.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/5316?email_source=notifications&email_token=AFAAEQ6B7DMIWCEC6C3EQKTQ64YOXA5CNFSM4HCQK2A2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWDNXMFI#event-2967172629,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQ4UDXCPNY5XNK73CWTQ64YOXANCNFSM4HCQK2AQ
.