Player: Improper cleanup when returning to the title screen

[fdelapena]

At least it seems the https://easyrpg.org/play/master/?game=tdf2018wildcompodemo&new-game misbehaves on restart, lacks some stuff, e.g. the first scene and missing the rotating "cube".

• [ ] Proper cleanup when --new-game is used with F12
• [ ] Proper cleanup after Game Over (See https://community.easyrpg.org/t/not-sure-if-this-has-been-documented-before/707/1)
• [ ] Proper cleanup after End Game

[fmatthew5876]

Probably load game is broken in similar ways.

We should be using RAII to automatically clean up stuff. Trying to do it by hand is asking for bugs.

[Ghabry]

This could be related to the awful "Game_Temp::restart_title_flag" invented by Sormat whose only purpose is to prevent a Reinitialisation (and BGM restart) when returning from Load to Title via Cancel button.

Maybe the flag is not set to "true" in all code paths.

That whole game-temp-restart-title-junk should be refactored, already hated it when it was added.

[Ghabry]

The problem here isn't the lack of cleanup but that the BGM is not stopped therefore the game reads the wrong value in the first frame of the game. ^^'

[Ghabry]

hm, no, there is also another problem... sorry. Now I see it.

[Ghabry]

@fdelapena
Can't find the PR but iirc I fixed this via https://github.com/EasyRPG/Player/commit/8e88e081d3d18bba8d9169cc85ddf9f0c2fcbcb2
Was there anything left?

[fdelapena]

Tested with current master and it's still broken but in a different way. Also, when pressing F12 behaves even different.

[Ghabry]

Also broken when Game Over happens as documented here: https://community.easyrpg.org/t/not-sure-if-this-has-been-documented-before/707/1

I already had multiple times (though randomly) that the title screen graphic does not appear anymore after pressing F12.

Lets take this issue as a catch-all for any bugs related to teardown.

[fmatthew5876]

2023 might help with this.

[fdelapena]

Played tdf2018wildcompodemo in recent master, the demo works flawlessly now after playing the loop :+1:

[rueter37]

If you play a RPG Maker 2003 game and the System2 graphics have been set once (which happens if you enter a RPG Maker 2003 battle) and then you exit the game and start an other RPG Maker 2003 game via the browser the System2 graphics from the first game are still used. This leads even to "checkered" graphics if the System2 filename from the first game doesn't exist in the second game.