Player: Automatic scrolling background images sometimes jump

[carstene1ns]

Did not test this with RPG_RT, but it seems like a glitch:

Related: #314 and #455.

[Ghabry]

Yepp they jump at the map boundaries when the map is looping.

[fdelapena]

Note: it does not jump in map boundaries if the panorama has automatic scroll, then the jump position will vary.

[carstene1ns]

Wow, I do not know what I am trying to achieve here, but this seems already been fixed by an unrelated commit before 0.4.0.

[carstene1ns]

At least in _.flow_ and _Yume Nikki_ it can not be observed anymore.
However, in _Standstill Girl_ in Shadeling Town (start map, just go to the hospital) it still happens. Reopening.

[scurest]

I think this is this typo

diff --git a/src/bitmap.cpp b/src/bitmap.cpp
index e54fb610..307f4b35 100644
--- a/src/bitmap.cpp
+++ b/src/bitmap.cpp
@@ -676,3 +676,3 @@ void Bitmap::TiledBlit(int ox, int oy, Rect const& src_rect, Bitmap const& src,
    if (ox >= src_rect.width)   ox %= src_rect.width;
-   if (oy >= src_rect.height)  ox %= src_rect.height;
+   if (oy >= src_rect.height)  oy %= src_rect.height;
    if (ox < 0) ox += src_rect.width  * ((-ox + src_rect.width  - 1) / src_rect.width);

[Ghabry]

looks like a candidate, obviously wrong 👍

[carstene1ns]

Good find, will test later today, if this fixes the issue in Standstill Girl. Going by the commit info, this bug has been present since 2012 at least... 😲

[Ghabry]

yeah this bug exists since looping maps were implemented because Yume Nikki needed them to be playable. :D

[carstene1ns]

confirmed fixed.