Pkp-lib: Make wording of editorial team consistent in backend and frontend

Created on 13 Apr 2017  路  9Comments  路  Source: pkp/pkp-lib

I think the different wording for the editorial team page (.../about/editorialTeam) at the backend is confusing.

Backend:
editorialTeam_backend

Frontend:
editorialTeam_frontend

I would propose using the term "Editorial Team" instead of "Masthead" at the backend. This way backend and frontend would be consistent. I would propose to change this in OJS and OMP.

Following keys are relevant: manager.setup.masthead in manager.xml and about.editorialTeam in locale.xml.

I would add the locale manager.setup.editorialTeam and simply copy the string from about.editorialTeam to the new locale (and change all calls of the locale in the code ...). I can do this for all languages (that have the about.editorialTeam locale), this way no new translation work would be needed.

I would also change the storage of the string in the database from masthead to editorialTeam.

I can create pull requests next week. 馃尀

Most helpful comment

This sounds like a sensible change -- go for it!

All 9 comments

@stranack, any preferences?

I changed the wording of the input for the editorial team at the backend from masthead to editorial team in all languages that have the key manager.setup.masthead (These languages do not have it: ca_ES, cs_CZ, eu_ES, hr_HR, nl_NL, pt_PT, sr_SR, sv_SE, tr_TR, uk_UA, zh_CN) and in the table journal.settings.

Backend:
editorialTeam_backend

Frontend:
editorialTeam_frontend

Thanks @lilients, I'll wait for @stranack to say... then I can take a look at the PR... :-)

This sounds like a sensible change -- go for it!

@lilients, those are the PRs, correct? -- Did I miss something?

Still missing translations:
OJS: eu_ES, hr_HR, nl_NL, tr_TR, zh_CN

thanks @bozana!

Was this page helpful?
0 / 5 - 0 ratings