Pkp-lib: Make consent statements less "Canadian" / more declarative

[jmacgreg]

1) Change:

Yes, I would like to be contacted about this submission.

TO:

I agree to be contacted about this submission.

2) Change:

Yes, I would like to be contacted with requests to review submissions to this journal.

TO:

I agree to be contacted with requests to review submissions to this journal.

@NateWr / @ajnyga, any concerns with the above phrasing change? We've had this request from a client who had some editors who were confused by the vagueness of the original text. Alternatively we could use "consent to" instead of "agree to".

[NateWr]

No objections. I deliberately wrote it to sound less like legalese. I think the idea of an "agreement" between parties is not a lay understanding of user registration, even if it is the legal interpretation of the act. But until OJS has someone setting and enforcing language standards across the platform it doesn't make much sense to quibble too much about this.

[ajnyga]

Sounds good to my non-native ear. I can see how that works better.

[ajnyga]

(also, I promise to use "more Canadian" and "less Canadian" from now on here in Github)

[jmacgreg]

Hi @NateWr, any chance you can have a quick review here? Probably mostly just to make sure I'm doing the whole PR process correctly (including tagging the commits with the bug ID, etc.). I'll have more to come later today, so I just want to make sure my procedure looks good. I can apply these to master + OMP as well.

[NateWr]

:+1: looks good.

One thing you'll want to watch out for: I can see that you've modified the ojs-stable-3_1_2 branch in your fork and you're issuing the PR from there. This is ok _as long as your PR is merged_.

If there's a delay in merging, or there's a change in decision and it won't get merged, your ojs-stable-3_1_2 branch would then fall out of sync with PKP's. The only way to fix this would be to destroy your branch and rebuild it.

Typically, when making a change, even on a non-master branch, you will create a new branch on your fork:

# i123 = issue 123
git checkout -b i123_name upstream/ojs-stable-3_1_2
git add .
git commit -m "pkp/pkp-lib#123 Whatever"
git push -u origin i123_name

That way, if things don't go to plan, you can put aside your branch and still update ojs-stable-3_1_2.

I've merged your PR so no worries on this one. You should be able to pull to update your fork's ojs-stable-3_1_2 branch. Just something to consider for the future. :+1: