Piranha.core: Code Convention

[tidyui]

As reference to PR #215 I wan't to get feedback if there is an overwhelming support for changing the code convention of the entire code base to Microsoft Standard, i.e:

• Opening braces on new lines
• Starting class members with an underscore
• And so on...

I personally don't like the standard, but if the support for such a change would be overwhelming I would still consider refactoring the code base as it is intended for everyone to collaborate on :)

Let me know what you think!

Peace

[Manuel-S]

I'm still evaluating whether to adopt Piranha, but for the sake of discussion I can say that I generally try to use the language specific code convention, because it will be familiar to everyone.

Have a look at: https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md

The only gripe I personally have with the ms C# style is the leading underscore on fields.

[tidyui]

My main concern is that I really dislike putting braces on new lines. I just like seeing as much code as possible on screen, BUT I am totally aware that this is a result of that I started programming when 640x480 was the highest resolution available 😁 Since I work on a retina screen nowadays I could accept moving the braces down.

The reason for aligning the code to the default settings in Visual Studio would of course be to make it easier for people to contribute to the project.

[psijkof]

I recognize your thinking about the braces, but I also have settled for it.
Glad to read this decision.

[willwolfram18]

I'm of the opinion that, while I understand wanting to be able to fit more onto a screen, having that spacial separation and clear definition of "yes, we are in a new block statement of some kind now" aids in readability. Granted, I've finally learned to let go of the curly brace position holy war, but I generally prefer to see curlis on separate lines. However, I strongly disagree with the statement from the linked conventions that "single line statement block can go without braces" because I have seen many a bug result from adding a line to a "block" and not realizing braces weren't there.

While I like to stick with the coding conventions and style guidelines for the language I am in, I have found that as long as the conventions in the project itself are consistent, then it doesn't really matter as long as the code quality itself doesn't suffer as a result. My personal vote would be to update to align with the C# conventions, but I vote it's not necessary unless people are that aggravated by the styles that it significantly reduces the number of contributors.

[psijkof]

Perhaps this is a good example?
Coding Conventions Orchard Core

[tidyui]

Most of the code has been converted. I will finish the final parts of the repo as I get the time!