Picongpu: ADIOS: Require Post-1.13.0

[ax3l]

Due to a large amount of fixed issues in ADIOS <= 1.13.0 regarding transforms and particle data, we will need a newer release of ADIOS.

Full list:

https://github.com/ornladios/ADIOS/issues/170

• reads:
  
  
  
  • https://github.com/ornladios/ADIOS/pull/162
  
  
  • https://github.com/ornladios/ADIOS/pull/163
  
  
• writes:
  
  
  
  • zlib https://github.com/ornladios/ADIOS/pull/165
  
  
  • bzip2, isobar and zfp https://github.com/ornladios/ADIOS/issues/174
  
  

Update the ADIOS dependency.

[ax3l]

@pnorbert do you already have an idea when the next ADIOS release is planned?

[pnorbert]

No, we don't. We kind of trail away from the six month cadence of releases of adios 1.x since we fully focus on developing adios 2.x. Rather, we just make a release when we have enough stuff to do that. However, we can make a new release any time your team needs. What is your timeline?

We also have updates on SZ and new feature ZCHECKER from the same researchers, and a new lossy compression MGARD from Mark Ainsworth, so actually we can make this a 1.14 release. But we have to work on the autotool/cmake builds and on documentation before we make a release. So give us at least a month ;-)

[ax3l]

Ok, that's great!

We are just in the planning to release a new major PIConGPU version and would like to have all dependencies in a fixed stable version as a dependency again, that's why I am asking about 1.14 (or a 1.13.1 with just fixes as above). If we depend on a untagged dependency for stable releases we can't describe the state of our software reliably and it makes documentation and user support a mess.

[pnorbert]

Understandable. So when do you need to have a new adios release to be available?

[ax3l]

A few weeks is fine, if you say a month that will work as well.

[pnorbert]

@ax3l Can you try the new package on your system with your app to make sure it builds and runs fine?
https://users.nccs.gov/~pnorbert/adios-1.13.1.tar.gz
Then we can publish the new release.

[ax3l]

@pnorbert thank you so much for the backport!
I quickly checked the patch diff with the 1.13.0 release and this looks good already.

cc @n01r : can you do a RT test? I guess you have data at hand that triggered the issues.

[n01r]

Will do!

I'll edit this command and compile my findings.

EDIT
So what I first noticed was that when you install the numpy wrapper from source, the output still shows:

...
/opt/cray/pe/craype/2.5.12/bin/CC -pthread -shared -B    \
    ...
    -L/users/mgarten/lib/adios-1.13.1_nompi/lib
...
Writing <path>/lib/python3.6/site-packages/adios-1.13.0-py3.6.egg-info

Also, the .../lib/python3.6/site-packages/adios/__init__.py shows

from .adios import *
__version__ = '1.13.0'

Is that intended because nothing much changed in the numpy wrapper or should the version number be 1.13.1 as well here?

EDIT 2
Running a minimal example, executing bpmeta (as well as bpmeta -z) and bpdump as well as reading with the numpy wrapper all seem to work fine.

:ping_pong: ping @ax3l

[n01r]

Okay, did the RT and it seems all fine :)
Thanks @ax3l and @pnorbert!

[pnorbert]

Thanks for the note, fixed it and now the release package is in
https://users.nccs.gov/~pnorbert/adios-1.13.1.tar.gz
Documentation is in https://users.nccs.gov/~pnorbert/ADIOS-UsersManual-1.13.1.pdf

[ax3l]

@pnorbert thank you so much, that's super helpful for us!