Phpunit: Remove "hack" in JUnit logger

[sebastianbergmann]

I just stumbled upon

https://github.com/sebastianbergmann/phpunit/blob/e5cf7828f463ebc970d041ef75af643ca56f9f7b/src/Util/Log/JUnit.php#L372-L379

Can @mrook (or somebody else from @phingofficial) provide feedback whether this method is still needed? Ideally I would like to remove it. At the very least I would like to change /*bool*/ $flag to bool $flag. The latter would not be a BC break as the class in question is not covered by the backward compatibility promise for PHPUnit.

[mrook]

Thanks for raising this! As of right now we are still using it. I'll see if we can drop "our" end of the hack, changing it to bool $flag would not be a problem for us.

[mrook]

Tagging @siad007 from @phingofficial.

[epdenouden]

@sebastianbergmann looks like it can be bool without any fear of breakage:

@mrook @siad007 looks safe to you, too?

[sebastianbergmann]

Already is bool as of 21ee615b3e8ce3f3e7282956555b1491debb55a6.

[siad007]

@sebastianbergmann feel free to remove the entire hack. It is not needed any longer. See https://github.com/phingofficial/phing/pull/1061