Phpunit: Deprecate annotation(s) for expecting exceptions

Created on 10 Oct 2018  路  4Comments  路  Source: sebastianbergmann/phpunit

Most helpful comment

Note for interested folks:
PHP CS Fixer has a rule to automatically apply this change and convert those annotations into methods call: php_unit_no_expectation_annotation

All 4 comments

Note for interested folks:
PHP CS Fixer has a rule to automatically apply this change and convert those annotations into methods call: php_unit_no_expectation_annotation

@sebastianbergmann , would it make sense to deprecate those annotations at 7.5 and drop at 8.0 ?
As always, I'm happy to help on that

While I initially wanted to do that, I do not think that the two months between December and February are enough for a deprecation period.

I believe it's fine - one thing is that it's not that short - but other, not everyone will migrate to new MAJOR at beginning of February.

looking at packagist stats ( https://repo-stats.github.io ), fragmentation is big
screenshot from 2018-10-11 13-48-38

for that, I believe it's worth to do it now instead of setting up a deprecation that would live for more than year.

Was this page helpful?
0 / 5 - 0 ratings