Php-parser: public always true

[alexander-akait]

Input:

class MyClass
{
    function myFunction() 
    {
        // Nothing
    }
}

function always interpreted as public. Maybe we can add hiddenVisibility: true (maybe best name)?

Based https://github.com/prettier/plugin-php/issues/72

[ichiriac]

I'm agree with you, initially the AST was made to act as the PHP engine acts, so the public visibility is implicit.

Yes, I could disable https://github.com/glayzzle/php-parser/blob/master/src/parser/class.js#L248 so when not public keyword is used, the visibility flag could be -1.

I could release it as a breaking change, v3

[alexander-akait]

@ichiriac will be great :+1:

[ichiriac]

@evilebottnawi, now the visibility property is empty when the keyword is not defined.

[alexander-akait]

@ichiriac thanks!

[alexander-akait]

@ichiriac it is work for const public const OTHER_CONST = 'value'; ?

[ichiriac]

@evilebottnawi yes, the visibilty should be node.visibility = "public" in this case

[alexander-akait]

@ichiriac can you release patch with this changes?

[ichiriac]

I will work on php-parser bug this week, and I'll release it under 3.0.0-alpha

[alexander-akait]

@ichiriac Awesome :+1: