Php-parser: Don't have curly for propertylookup in offset

[alexander-akait]

Example:

$this->{quantity};

Ref: https://github.com/prettier/plugin-php/issues/112

[czosel]

This might be a duplicate of #101

[ichiriac]

Not really, here the problem is about unclear AST. In fact it's not really a bug as the output can be resolved as following :

If the name is an identifier node, use '{' + name.name + '}' or else use directly name.

I find it a bit ugly, so I'll use this version in order to introduce changes on AST and make it more intuitive, related on https://github.com/glayzzle/php-parser/issues/62

[czosel]

Oh, of course - and it's not even about encapsed. I guess i should take a break :wink:

[czosel]

@ichiriac the workaround in our prettier plugin is actually not too bad: https://github.com/prettier/plugin-php/pull/183

[alexander-akait]

/cc @ichiriac friendly ping, after some delay let's solve this issue, any ideas how better solve this?

[ichiriac]

Hi @evilebottnawi,

I'm sorry that my reply took so long, I'm almost free & back now. I'll work this saturday all the day, I still plan to release it on a stable version soon.

I wish you an happy new year plenty of joy and cool projects :smile:

[ichiriac]

Hi @evilebottnawi,

Could you check remaining issues and add the flag high-pri on every issue you need to be fixed for the stable version ? Like this I'll know on what to focus.

[ichiriac]

hi, it's implemented, take a look at the comment https://github.com/glayzzle/php-parser/issues/248#issuecomment-456596682 in order to see the implementation rules