Patternfly-react: SelectOptionObject does not show checked items for Select component

[dlabaj]

Currently the SelectOptionObject does not show the checked items when used with a checked variant of Select. A work around for now is to map the select object to strings which will allow it to be displayed as checked with in the Select check variant.

The code here:

https://github.com/patternfly/patternfly-react/blob/4abb5b6e766ff1c669423dcb7cafc29fe4b02464/packages/react-core/src/components/Select/SelectMenu.tsx#L106

and here:

https://github.com/patternfly/patternfly-react/blob/4abb5b6e766ff1c669423dcb7cafc29fe4b02464/packages/react-core/src/components/Select/SelectMenu.tsx#L119

Should be updated to support SelectOptionObjects.

[dlabaj]

Closing issue after looking at code.

[nicolethoen]

I have a dev still coming up against this issue. If there is a work around, can it be documented somewhere?

[kmcfaul]

@nicolethoen The workaround is to use strings for value, mentioned at the top. For customized display, the children property of SelectOption may be used instead of SelectOptionObject's toString function.

[dlabrecq]

The SelectOptionObject now displays the checked items, but shows the wrong total checked items.

See https://github.com/patternfly/patternfly-react/issues/4478