Patternfly-react: Horizontal form renders buttons in a column

Created on 15 Jun 2020  路  5Comments  路  Source: patternfly/patternfly-react

Describe the issue. What is the expected and unexpected behavior?

image

https://patternfly-react.surge.sh/documentation/react/components/form#horizontal

Buttons should be in a row, not in a column.

Is this a bug or enhancement? If this issue is a bug, is this issue blocking you or is there a work-around?

Bug. Blocking.

What is your product and what release version are you targeting?

Sources UI
We have a deadline for the upgrade on 7/6/2020.

bug

Most helpful comment

@rvsia @Hyperkid123 we're working on getting this into the current milestone for release next week

All 5 comments

cc @Hyperkid123 @karelhala

cc @evwilkin @tlabaj

@tlabaj @mcoker it looks like the horizontal form has these styles applied for all .pf-c-form__group, including the .pf-m-action element containing the buttons circled in the screenshot above.

Should these styles be overruled for the .pf-m-action element?

Screen Shot 2020-06-15 at 1 20 10 PM

@evwilkin @tlabaj looks like the .pf-c-forms__actions element needs to be wrapped in .pf-c-form__group-control. Anything that belongs in the form control/elements section (the things on the right in a horizontal form) needs to be wrapped in .pf-c-form__group-control.

@rvsia @Hyperkid123 we're working on getting this into the current milestone for release next week

Was this page helpful?
0 / 5 - 0 ratings