Patternfly-react: PF4 expandable compact table missing styling

Created on 12 Mar 2019  路  11Comments  路  Source: patternfly/patternfly-react

Example: https://react-pf-playground.stackblitz.io/

Screenshot:

Screen Shot 2019-03-12 at 9 22 52 AM

If you use the compact table with the expandable rows, the blue line is missing from the left side.

Not sure if this is intentional or not, but our mockups have the blue line

PF4 p1 rc.1

Most helpful comment

Ok, thank you for letting me know!

All 11 comments

Hi @ryelo can you list any product/project release(s) and timelines your trying to align with, and is this currently blocking documentation?

Timeline, as soon as possible? (before summit?) Would make our table a lil prettier (insights rule table)
Screen Shot 2019-03-12 at 9 36 52 AM

Ok, thank you for letting me know!

@rachael-phillips This is affecting nearly all of the apps inside of Cloud Services, preferable asap. We're trying to harden and get as close to mockups as possible, but this is creating readability issues for larger expandable items.

Thank you for the explanation. I've placed the highest priority label on this issue.

@mcoker can you advise on this one? Is this an implementation bug or something we would need to update in Core?

@rachael-phillips I chatted with @mceledonia and will make an update in core.

@ryelo here's the PR in core - https://github.com/patternfly/patternfly-next/pull/1563

Once it's merged, we'll just need to bump the version of core in patternfly-react.

Added breaking change label due to it being a breaking change in core.

Removing the "on hold" tag since the core PR has been merged

Fixed in 3.x release.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rvsia picture rvsia  路  5Comments

andrewballantyne picture andrewballantyne  路  4Comments

priley86 picture priley86  路  3Comments

priley86 picture priley86  路  3Comments

rvsia picture rvsia  路  4Comments