Patternfly-react: Chip - allow chip to be read-only

Created on 5 Mar 2019  路  8Comments  路  Source: patternfly/patternfly-react

When setting the Chip as readOnly, that would remove the X next to it but keeping the same height

PF4 open-pr p1 rc.1

All 8 comments

@gastaldi do you mind providing us a little more context on what you'd like to achieve? @mcoker making you aware.

@rachael-phillips sure, for example, in the first Chip Group Toolbar
example in http://patternfly-react.surge.sh/patternfly-4/components/chipgroup, I'd like to avoid Chip 1 to be removed, but others may be removed (as if Chip 1 were a required chip).

Therefore having the ability to mark a specific chip as readOnly would be really helpful

@rachael-phillips we should ask design if there should be any other visual indicators that the chip is read-only/non-removable, or if it's simply removing the button but keeping the existing overall layout, and then add an issue in core to add this variation.

I think simply removing the icon button should be fine for this. If we start getting a lot of feedback that people aren't understanding why they can't remove the chip, we can reconsider.

Ok great! Thanks everyone!

I added the on hold label so that we can resolve this in our Core repo first (1533 Create read-only variation of chip). Then we will move it onto React. Thanks everyone!

@rachael-phillips this is in core now and ready to be added to react - https://github.com/patternfly/patternfly-next/pull/1555

Closed by #1639

Was this page helpful?
0 / 5 - 0 ratings