Parity-ethereum: Log Rotation Support

[mtrubs]

We run 1.10.4 stable via Docker on Ubuntu 16.4 are fully synced and connect to ethereum mainnet.

It would be useful to support some form of log rotation. This would allow us to keep the node up 100% of the time while keeping disk space in check. This could either be managed internally (but of course means more things to maintain). Or it could be managed by support for a utility like logrotate. In order for something like that to work there needs to be a command to reload the log files.

Nginx for example does this via:
kill -USR1 `cat /var/run/nginx.pid`

Passenger has a similar option to reload application logs:
passenger-config reopen-logs

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 0.8 ETH (366.68 USD @ $458.35/ETH) attached to it.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $16,627.94 more funded OSS Work available on the Gitcoin Issue Explorer

[gitcoinbot]

Issue Status: 1. Open 2. Cancelled

---

__Work has been started__.

These users each claimed they can complete the work by 7 months ago.
Please review their action plans below:

1) MyS5Droid has been approved to start work.

I can help if the log file is in the host system, not the docker continer... If the logfile is on the host system, or it is possible to ssh into the docker container, I can:
1) Install LogRotate
2) Create shellscript to invoke log rotation
3) Install it in /usr/bin or /sbin

Learn more on the Gitcoin Issue Details page.

[vs77bb]

@vikasyadav could you expand on the additional details you are looking for here?

[ghost]

Hi, I am available for work immediately

I actually started work on this... However, I need to know the following:
1) How often to rotate logs (daily, weekly, monthly)
2) How many log rotations to keep (2, 6, 10, etc?)
3) Do you want to compress the log files?
4) Do you want to restart parity afterwards?

I am pretty much done a fork that can be merged into the main branch.

Sorry I got carried away when I looked at it :P

[ghost]

Please note: The repository I referenced below is currently UNSTABLE and should not be run on a STABLE server, only on a TESTING server!

I have something to test, if you want here... It is WIP so sometimes not working but I am making loads of progress :)
https://github.com/MyS5Droid/parity

The main file changed:
https://github.com/MyS5Droid/parity/blob/master/docker/ubuntu/Dockerfile

Added some /scripts and a /config/default.config.toml

I still need to make it restart parity using the default config file location if you want it to do that.

Log rotation script is in /usr/local/bin/rotate-parity-logs.sh inside the container.

I also added configuration variables inside of /config/default.config.toml which are needed for the logrotate function. Either use it, or combine them into the documentation when I am finalized.

[gitcoinbot]

@vikaskyadav Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[vikaskyadav]

@MyS5Droid

We can rotate the logs daily at some time in the early morning. 2-4 log rotations are good to keep. I don't think there is any need to compress the files right now.

[ghost]

@mtrubs & @vs77bb :

I got the issue owners mixed up. Once vikasyadav's application expires, could you please approve mine to secure my position? I am nearly done, just hammering out the rest of it. I am attempting to provide more than asked and be sure it is done right with documentation :)

Question 1: _If you like I could hack together a quick docker image that will work for only you_ (everything hard coded) so you could implement it now... Then I could work on the rest (making it useable with config options, spreading it to other docker architechtures, documentation, etc.) later.

Question 2: Are you using the default config file location ( ~/.local/share/io.parity.ethereum/config.toml ) or specifying your own?

Question 3: Are you using multiple docker/parity instances with multiple config files? How are your config files named? Where are they located on your computer/server?

My intentions are to standardize this so it can be merged into the main branch, and used by any user using parity on any system whether manually installed or run inside Docker container.

[vikaskyadav]

@MyS5Droid It was supposed to be a group task dude. Since you already took
charge that's why I am trying to cross-check all the milestones. Don't do
this again! @vs77bb please take note of this.

[ghost]

@vikaskyadav no it was not... Don't do what again? What did I do that was wrong? I believe I am in the right here... You disappeared, failed to respond and nearly got kicked off the project by Gitcoinbot.

I responded for the issue owners so they can get the issue resolved ASAP. You can't just apply for many projects, disappear, and then when someone else works on it, come back and say "oh I actually meant to do that" when you were not communicating with the owners. They asked you a question, and you never answered.

Issue type is "Traditional". If you wanted a multiple coder project you should have selected "Contest" or "Cooperative". This is also my first time using Gitcoin, so I thought you were the issue owner and you accidentally applied for your own issue. That is why I said "I got the issue owners mixed up". So as far as I knew, you were the owner, and there was no one working on it so I applied.

How can you update milestones without writing code? You need to write code to hit a milestone... I am not giving you mine. I will check my own check boxes thank you :)

Next time, please answer the Gitcoin bot, or answer the issue owners... Don't just disappear and then come back when the project is near done to claim your steak.

Not fair dude. Don't do that again. If you wanted the project you should have responded to the owner's question, and also to the Gitcoin bot who was warning you. Forgive me for being first time Gitcoin user, wanting to solve the issue ASAP, and being proactive.

@mtrubs & @vs77bb which one of you owns the issue and can straighten out whether it was a group project or not? Because my eyes are telling me it is "Traditional" Gitcoin project... Were you aware of vikaskyadav having started working before being approved?

I only started work in case vikaskyadav was removed, I figured if he did take his first dibs I would take my code to my own project... Then if he disappeared then I would have your project done for you and ready for submit... Not sure how that is wrong to start working ASAP when it benefits my projects as well. What kind of world punishes proactiveness in IT?

@everyone: Where is the Gitcoin bot? It _was_ here...

[vikaskyadav]

Are you dumb man? Didn't you see me on the task before starting the work?
Who the hell are you and why should I respond to you?? That is the issue
between me and the repo owner. You don't need to work on someone else's
task till the time somebody has got charge of it. Just understand this. and
it's not of your concern even if I am running of from the project. Mind
your business and see how gitcoin works. @vsbb take note of this guy please

[mtrubs]

Lets keep this professional and cordial.

I am a ticket submitter. We use parity. I am not otherwise associated with the parity repos or organization.

So the way we use it is just by pulling the docker image. We use pretty much the default setup. We can easily setup logrotate ourselves but if the docker image does that too thats even easier. I think logrotate is the easier part. The parity code needs to support the notion of reloading the logs. Otherwise logrotate will do its thing but the file reference in memory would still use the original. You can restart the process but that seems a little hack-ish to me. Thus the ask for a command to trigger the log reload and make logrotate usable.

Thanks.

[vikaskyadav]

Yeah, It would be better if docker image does that automatically. Some
scheduler will do in this scenario. Even hacky way will do for reloading
the log.

[vs77bb]

@vikaskyadav @mtrubs @MyS5Droid To clear things up from the Gitcoin side, this is listed as a 'Traditional' ticket with 'Applicants', one of which is to work independently on the ticket. In this case, I'd agree that @MyS5Droid has made progress on this ticket and thus should be the applicant who moves forward.

I'd like to take responsibility for not approving a worker sooner. @vikaskyadav Feel free to reach out to me directly on Slack if you'd like to discuss this further. If you send over any information on work you've done for this ticket, it would help assess if it makes sense to tip accordingly for the confusion.

@vikaskyadav We love having you around on Gitcoin, but I'd agree wholeheartedly with @mtrubs that professionalism and community is of utmost importance (as per our contributor guidelines) and would appreciate if you refrained from ad-hominem attacks.

@mtrubs + @MyS5Droid, would love to see you all move this forward to completion from here 👍

[gitcoinbot]

@vikaskyadav Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@MyS5Droid Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[vikaskyadav]

Check with @MS5Droid. I am off with this bounty.

[image: Mailtrack]
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality3&
Sender
notified by
Mailtrack
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality3&

On Sun, Jul 22, 2018 at 9:45 PM, Gitcoin.co Bot [e-mail]
wrote:

@vikaskyadav https://github.com/vikaskyadav Hello from Gitcoin Core -
are you still working on this issue? Please submit a WIP PR or comment back
within the next 3 days or you will be removed from this ticket and it will
be returned to an ‘Open’ status. Please let us know if you have questions!

• warning (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day
https://gitcoin.co/issue/paritytech/parity/8709/744?snooze=1 | 3 days
https://gitcoin.co/issue/paritytech/parity/8709/744?snooze=3 | 5 days
https://gitcoin.co/issue/paritytech/parity/8709/744?snooze=5 | 10 days
https://gitcoin.co/issue/paritytech/parity/8709/744?snooze=10 | 100 days
https://gitcoin.co/issue/paritytech/parity/8709/744?snooze=100

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/paritytech/parity-ethereum/issues/8709#issuecomment-406878511,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMBh1z4bsC3gbCb-gue9eSHtMpHTqSfoks5uJKUhgaJpZM4UMYq7
.

[mtrubs]

@MyS5Droid what is next in order for my support of your?

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@MyS5Droid due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• [x] warning (3 days)
• [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@vikaskyadav Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[vs77bb]

Hi @MyS5Droid do you have an update here?

[gitcoinbot]

Issue Status: 1. Open 2. Cancelled

---

__The funding of 0.8 ETH (219.17 USD @ $273.96/ETH) attached to this issue has been cancelled by the bounty submitter__

• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $19,358.67 more funded OSS Work available on the Gitcoin Issue Explorer

[gitcoinbot]

Issue Status: 1. Open 2. Cancelled

---

__The funding of 0.8 ETH (219.17 USD @ $273.96/ETH) attached to this issue has been cancelled by the bounty submitter__

• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $19,358.67 more funded OSS Work available on the Gitcoin Issue Explorer

[adria0]

Closing issue due to its stale state.