Parity-ethereum: parity_setTransactionsLimit is deprecated and needs replacement

Created on 14 Feb 2019  路  3Comments  路  Source: openethereum/parity-ethereum

  • Parity Ethereum version: v2.1.10-stable-b47e064f8-20181213
  • Operating system: x86_64-macos/rustc1.31.0
  • Installation: one-line installer
  • Fully synchronized: yes
  • Network: ethereum dev
  • Restarted: no / yes

  • actual

MacBook-Air-de-Jordi:rust-web3 jordi$ curl --data '{"method":"parity_setTransactionsLimit","params":["0x3e8"],"id":1,"jsonrpc":"2.0"}' -H "Content-Type: application/json" -X POST localhost:8545
{"jsonrpc":"2.0","error":{"code":-32602,"message":"Invalid params: invalid type: string \"0x3e8\", expected usize."},"id":1}
  • expected behavior
{"jsonrpc":"2.0","result":true,"id":1}
  • steps to reproduce the issue.
parity --chain dev
curl --data '{"method":"parity_setTransactionsLimit","params":["0x3e8"],"id":1,"jsonrpc":"2.0"}' -H "Content-Type: application/json" -X POST localhost:8545
F5-documentation 馃搼 F8-enhancement 馃帄 M6-rpcapi 馃摚

Most helpful comment

The method is deprecated anyway since it doesn fully match current transaction pool method. If you feel you need to control transaction pool limit over RPC, please open a separate issue, we will think of a way how to revive it (basically there are multiple limits in place currently, it would be good to have one RPC method for everything).

@joshua-mir would you mind updating the docs?

All 3 comments

The method is deprecated anyway since it doesn fully match current transaction pool method. If you feel you need to control transaction pool limit over RPC, please open a separate issue, we will think of a way how to revive it (basically there are multiple limits in place currently, it would be good to have one RPC method for everything).

@joshua-mir would you mind updating the docs?

Actually I don't need to control the transaction pool limit over RPC. I noticed the method not working when implementing parity_set.
I don't think its a must or a core feature to be solved right now, but yes! would be nice to have one RPC method for all this related things. We can think about that.

Closing issue due to its stale state.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

vmenond picture vmenond  路  3Comments

barakman picture barakman  路  3Comments

area picture area  路  3Comments

stone212 picture stone212  路  3Comments

jurijbajzelj picture jurijbajzelj  路  3Comments