Paper: [Feature] Improvement to #524

[hurrgurl]

Can we have an option to regenerate a chunk with book exploit instead of just reporting it to the console?

chunk-regen-on-bookexploit: true

Cause who needs that chunk anyway, right?

Instead of this i think removing oversized objects in a chunk file would be a better solution.

[ShaneBeee]

You really want that on your server?
A player logs on, and the entire chunk they have built in is just regenerated? And then they start complaining to the server staff that they lost all their stuff?

Yeah... its totally their fault for trying to exploit but is it really fair to them to just up and delete ALL their stuff without warning?

[hurrgurl]

That's why you make it an option. In any case, it is fair to delete everything owned by an exploiter.

[PhanaticD]

then they would go exploit in other peoples bases to grief them

[mikroskeem]

This has more downsides than upsides, so in my opinion this shouldn't be implemented into Paper.

You can stick to patching Paper yourself or use mixins via custom solutions.

[UnioDex]

No, that would be a big problem. Players can put oversized books to the chunks where they want to remove. If i'm not wrong they can do it even with dropping items.

Instead of this i think removing oversized objects in a chunk file would be a better solution.

[hurrgurl]

@UnioDex
True, you can do that.

[aikar]

an option to auto remove large items is reasonable, ill see about it on monday, or someone can PR it.

If anyone does PR, I think we can put that in paper.yml under settings as key:

settings.oversized-chunks.delete-large-objects-over-kb:
settings.oversized-chunks.type-confirm-here-to-confirm-delete:
default value -1 or nothing for first
default empty string for 2nd

impl should only act if this value if the size is > the filter threshold AND the 2nd key has the word "confirm" written in it.

[hurrgurl]

The warning message still pops up in chunks that have many player heads stored within a chunk. Player heads in shulker boxes in a double chest.

The message pops up both on shutdown and start of the server, indicating that the items at fault were in fact saved to disk and did not cause a dupe.

[aikar]

@hurrgurl nothing should be able to dupe anymore. Are you sure it was only heads? that would of had to been A LOT of heads....

[hurrgurl]

It was at least one double chest full of shulker boxes filled entirely with different player heads in each slot. Heads range in amount from 1 to 64.

Didn't find any sign of dupe, but the dupe message was still logged.

May be worth mentioning that these heads were likely created using unholy methods in 1.7 and earlier versions. Found out about this weird stash just now, thanks to your notification.

Paper 529

[UnioDex]

@hurrgurl if you don't mind can you share the .mca file of that region? You can convert chunks to region from here:
https://dinnerbone.com/minecraft/tools/coordinates/

[BillyGalbreath]

I think a better option would be to fire an event for plugins to handle as they please when a chunk gets too big. Then the server admin can create/install a plugin that does what they want it to do with oversized chunks.

As for me, I like the idea of destroying a player's stuff if they are actively exploiting. I've been known to cause world explosions on piston/slime dupes, etc. With an event for this I could definitely come up with some creative and fun solutions to the exploiters. ^_^