Packit-service: It seems like Packit isn't triggering on PRs from contributors?

[puiterwijk]

In https://github.com/fedora-iot/zezere/pull/37, a contributor submitted a new PR and Packit never seems to have started, nor did it supply a comment with why not.

[jpopelka]

IMHO the same cause as in #482

[puiterwijk]

@jpopelka Except that this issue was 4 days ago, and not today. And it seems like Packit never even set the Pending status with links, which it did on the issues affected by #482?

[TomasTomecek]

So the use case is that a contributor submitted a PR and packit did not set any statuses on the PR. As far as I could tell while looking at the PR, the contributor did not have commit rights in repo.

@lachmanfrantisek could this be related to your giant refactor work?

[lachmanfrantisek]

@lachmanfrantisek could this be related to your giant refactor work?

Anything can be related...;) It's possible that I've removed the setting of the error status. But, it should be covered by tests... I/we need to take a look.

In the meantime, there were some changes related to this. Some rewording of messages and also the code changes (@csomh sent those changes if I remember correctly).

[csomh]

Was #445

[puiterwijk]

@TomasTomecek Yeah, at the time he submitted the PR (and Packit did not take action), the contributor did indeed not have write access to the repository.
After I ran "/packit build", it did get triggered, so I guess the issue comes down to that it didn't tell me I needed to run that :).

[lachmanfrantisek]

OK

So what can we do to improve that?

• Mention the /packit build in the comment if someone triggered the build via comment.
• On push, we show only a status:
  
  
  
  • Can we easily show that info there? (The length is very limited.)
  
  
  • Can we add a static URL (to docs?) with the instructions?
  
  
  • Creating comments also for this would be too spammy I think.
  
  

[TomasTomecek]

  * Can we add a static URL (to docs?) with the instructions?

Sounds good, I'd do that.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.
We are doing this to be sure that the issue is still relevant. Anyone can comment to remove the stale state. (The issues marked with pinned, security, bug or EPIC label
are not considered stale.)

[lachmanfrantisek]

Still needs a documentation update.

[stale[bot]]

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! :unicorn: :rocket: :robot:

(Note: issues labeled with pinned, security, bug or EPIC are
never marked as stale.)

[lachmanfrantisek]

  * Can we add a static URL (to docs?) with the instructions?

Sounds good, I'd do that.

@TomasTomecek Have you done that?

I see that we are using FAQ_URL = "https://packit.dev/packit-as-a-service/#faq" for whitelisting problems and no url for user permissions:

https://github.com/packit-service/packit-service/blob/aba85da2b1cd879d7df6c3b83ee57caf1f09490d/packit_service/worker/whitelist.py#L256-L259

https://github.com/packit-service/packit-service/blob/211fcb2333a58a718df5764d24c233e1429a7867/packit_service/worker/handlers/github_handlers.py#L270-L276

[TomasTomecek]

  * Can we add a static URL (to docs?) with the instructions?

Sounds good, I'd do that.

@TomasTomecek Have you done that?

I haven't :D

In this context, "I'd do that" meant that "I share your opinion and agree with it", not that "I'm going to do that". Will try to write more clearly next time.

Anyway, I'm going to send a PR right now.

[lachmanfrantisek]

In this context, "I'd do that" meant that "I share your opinion and agree with it", not that "I'm going to do that". Will try to write more clearly next time.

@TomasTomecek thanks. I did read that as I'll not I'd...;) Probably I wanted to see that.;)

[stale[bot]]

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! :unicorn: :rocket: :robot:

(Note: issues labeled with pinned, security, bug or EPIC are
never marked as stale.)

[stale[bot]]

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! :unicorn: :rocket: :robot:

(Note: issues labeled with pinned, security, bug or EPIC are
never marked as stale.)

[lachmanfrantisek]

Since the response has been improved by Tomáš and the code changed a lot since March, I am going to close this issue.

Please, create a new issue if you hit that problem again.

Thanks for letting us know about the issue!