Osu: Disable "Background source" setting for non-supporters

[elleyer]

Describe the bug:
"Beatmap source" isn't working correctly. (Maybe this should work another way?)
Screenshots or videos showing encountered issue:
https://streamable.com/1d2d4
osu!lazer version:
latest
Logs:
runtime.log

[bdach]

I can't seem to hit anything like this from a quick check, looks like it's working ok. Nothing in runtime.log that would point to a definite cause either from what I can see.

Does this happen reliably?

[elleyer]

Just skipped a part with "if the user is supporter". My bad, sorry. I think that we can add notification like "This option is available only for supporters".

[bdach]

Yeah, this setting probably shouldn't be even visible/editable to non-supporters then. Going to rename this to track that appropriately.

[peppy]

Skin source is also supporter only. Should probably be text in settings to mention this.

[Wieku]

My loose proposal

Without supporter:

With supporter:

I think we don't want to hide options for supporters because then users may not know that certain features exist.
And I think "Default" option should be added, because even supporters may want to have default backgrounds.

[peppy]

Looks fine, although the text should read "Changes to this setting will only apply with an active supporter tag."

[Wieku]

I thought about disabling the setting (e.g. opening background source dropdown is disabled when user doesn't have supporter tag) but now I think that letting user choose the setting anyway is better UX (in case they get the supporter soon after).