Osu: Home and notifications toolbar tooltip titles are title cased while others are lowercased

Created on 3 Sep 2020  路  3Comments  路  Source: ppy/osu

Describe the bug: For this specific issue, the casing regressed as we are now sharing code with overlays. Should all of them be lowercased?

As for all strings, we can avoid casing UI regressions by writing all strings in code lowercase, and then using their methods (e.g. ToLower{Invariant}) for the UI.

Screenshots or videos showing encountered issue:
osu!_2v5xWrYkTy
image

osu!lazer version: 2020.903.0

Logs: not needed

toolbar code-quality

Most helpful comment

My immediate thought is that toolbar text should probably not be all lower-cased if the description isn't. Upper case makes more sense to me.

Humanizer is better suited for capitalisation than To{Lower,Upper} - we should be using that.

All 3 comments

My immediate thought is that toolbar text should probably not be all lower-cased if the description isn't. Upper case makes more sense to me.

Humanizer is better suited for capitalisation than To{Lower,Upper} - we should be using that.

going by the website, the title links are lower case. so maybe we should make both lower in that case..

I could agree with both lower too. As long as they're not mixed.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Fatal3ty picture Fatal3ty  路  3Comments

smileyhead picture smileyhead  路  3Comments

stageosu picture stageosu  路  3Comments

LanTenDragon picture LanTenDragon  路  3Comments

smileyhead picture smileyhead  路  3Comments