Origin: Show consistent number of decimals in eth values

[wanderingstan]

We currently show different number of decimals everywhere we display a price in eth:

10 decimals

5 decimals

3 decimals

In discussion with @DanielVF and @joshfraser we casually settled on 5 decimals, as at current prices this makes the least significant digit roughly equal to one cent.

[micahalcorn]

Related: https://github.com/OriginProtocol/demo-dapp/issues/224

[DanielVF]

Yeah, I think for now go with five for ETH, and tooltip display a minimum of five with any extra needed decimals for the people with accounting in their blood.

[tyleryasaka]

@kayyoo23 is on this one!

[wanderingstan]

The latest release shows 3 decimals on user profile page, while listings show 5.

[micahalcorn]

Talk to @kayyoo23 😁

[kayyoo23]

Yesss I will finish this up tomorrow!

😂

On Tue, Aug 14, 2018 at 7:50 PM, Micah Alcorn [e-mail]
wrote:

Talk to @kayyoo23 https://github.com/kayyoo23 😁

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OriginProtocol/origin-dapp/issues/244#issuecomment-413078297,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AnE47tj-a2HdNzcTuX9CUppBQzdubkpAks5uQ4xzgaJpZM4UUQlO
.

--
Kay Yoo
Finance & Operations
Origin Protocol http://originprotocol.com

[micahalcorn]

Resolved by #337 💪

[kayyoo23]

💪

On Thu, Aug 16, 2018 at 2:21 PM, Micah Alcorn [e-mail]
wrote:

Closed #244 https://github.com/OriginProtocol/origin-dapp/issues/244.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/OriginProtocol/origin-dapp/issues/244#event-1793407092,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AnE47vENtTNnIyYvlEFDv8Tn43mPcZGkks5uReJTgaJpZM4UUQlO
.

--
Kay Yoo
Finance & Operations
Origin Protocol http://originprotocol.com

[micahalcorn]

@wanderingstan @joshfraser just documenting here that we discussed this again in today's product meeting and decided to leave everything at five-digit precision for now. As I see it, there are two separate questions:

• what level of rounding precision (3.14 vs 3.14159 vs 3.14159265359)
• whether or not to enforce consistent precision despite zeros (1 vs 1.00000)

Besides favoring no change because we didn't want to prioritize this debate, we tended to prefer the visual consistency of always displaying five digits. And in Origin Wallet, we are going to be showing gas cost, which more naturally lends itself to additional digits. Our hope is that stablecoins will become the most common denomination, in which case we can make the numbers more-closely resemble fiat.