Origin: Split listing detail component

Created on 29 May 2018  Â·  5Comments  Â·  Source: OriginProtocol/origin

At least the listing detail info box should probably be separated so that it can be reused in the purchase detail component.

enhancement good first issue htmcss javascript

Most helpful comment

STOP SENDING ME THESE FUCKING EMAILS!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

On Mon, May 28, 2018 at 7:58 PM, Micah Alcorn notifications@github.com
wrote:

At least the listing detail info box
https://github.com/OriginProtocol/demo-dapp/blob/master/src/components/listing-detail.js#L226
should probably be separated so that it can be reused in the purchase
detail component
https://github.com/OriginProtocol/demo-dapp/blob/master/src/components/purchase-detail.js#L513
.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/OriginProtocol/demo-dapp/issues/237, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AVChnte51ulfycIg0TK9yQkKns-RtxODks5t3I8TgaJpZM4UQrkz
.

--
Kind Regards,

Mike Premier
Marketing Director
The Premier Group Miami
Mr.[email protected]

All 5 comments

STOP SENDING ME THESE FUCKING EMAILS!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

On Mon, May 28, 2018 at 7:58 PM, Micah Alcorn notifications@github.com
wrote:

At least the listing detail info box
https://github.com/OriginProtocol/demo-dapp/blob/master/src/components/listing-detail.js#L226
should probably be separated so that it can be reused in the purchase
detail component
https://github.com/OriginProtocol/demo-dapp/blob/master/src/components/purchase-detail.js#L513
.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/OriginProtocol/demo-dapp/issues/237, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AVChnte51ulfycIg0TK9yQkKns-RtxODks5t3I8TgaJpZM4UQrkz
.

--
Kind Regards,

Mike Premier
Marketing Director
The Premier Group Miami
Mr.[email protected]

Is it fixed ? I will work on this.

@riverfor please do!

@tomlinton

@riverfor please do!

Yes, I am working on it. It looks like a little bit complex.

Resolved by #847 😊 (The listing detail section no longer exactly resembles that of listing-detail.)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

davecraige picture davecraige  Â·  5Comments

davecraige picture davecraige  Â·  8Comments

davecraige picture davecraige  Â·  3Comments

wanderingstan picture wanderingstan  Â·  9Comments

mikeshultz picture mikeshultz  Â·  4Comments