Operator-sdk: Replace the usage of `gopkg.in/yaml.v3` for `sigs.k8s.io/yaml`

Created on 7 Apr 2020  路  7Comments  路  Source: operator-framework/operator-sdk

What ?

  • Replace the usage of gopkg.in/yaml.v3 for sigs.k8s.io/yaml

Why?

  • Just to place is requiring the gopkg.in/yaml.v3 and then, we can use the module sigs.k8s.io/yaml which is already used in the project instead of.

Where?

  • pkg/ansible/watches/watches.go
  • pkg/helm/controller/controller.go

Notes: After the PR https://github.com/operator-framework/operator-sdk/pull/2786/files# will still 2 places that require some small refractures in order to allow us to remove the need for this dependency.

good first issue help wanted kincleanup

Most helpful comment

/assign

I've got a few branches for some of this already. I'll submit PRs today or tomorrow.

All 7 comments

Hi @estroz,

I am re-opening it. It still required.

/assign

I've got a few branches for some of this already. I'll submit PRs today or tomorrow.

Is this done?

Not yet @estroz. See: https://github.com/operator-framework/operator-sdk/search?q=replace+it+for+yaml+%22sigs.k8s.io%2Fyaml%22&unscoped_q=replace+it+for+yaml+%22sigs.k8s.io%2Fyaml%22

also, when it gets done we will able to remove the dep gopkg.in/yaml.v3 from go.mod

The only place this still remains is in pkg/ansible/watches/watches.go. I'll take a look at fixing that file as soon as I get a chance.

3 more locations: https://github.com/operator-framework/operator-sdk/search?q=%22gopkg.in%2Fyaml%22&unscoped_q=%22gopkg.in%2Fyaml%22

Bumping this to the backlog since this isn't a bug and shouldn't block a release.

There would be some modifications required after #3120 is merged. Usage of gopkg.in/yaml.v3 is required in the mentioned PR because of dependence on Operator Registry.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

hasbro17 picture hasbro17  路  3Comments

camilamacedo86 picture camilamacedo86  路  5Comments

camilamacedo86 picture camilamacedo86  路  4Comments

chowmean picture chowmean  路  5Comments

lsalazar1 picture lsalazar1  路  4Comments