Openzeppelin-contracts: `emit` in contract events for compatibility with solidity v0.4.21

Created on 10 Mar 2018 · 16Comments · Source: OpenZeppelin/openzeppelin-contracts

🎉 Description

As recent release of solidity has been introduced 'emit' keyword to use with events to differentiate them from functions. This will be great if contracts of repository are updated so that they can be used with latest solidity compiler.

[ ] 🐛 This is a bug report.
[x] 📈 This is a feature request.

💻 Environment

This upgrade will help to run the contract with latest solc compiler.

good first issue

Source

Aniket-Engg

All 16 comments

Seems like a reasonable task for an "update to 0.4.21" pull request, once 0.4.21 has been in the wild for a bit

shrugs on 12 Mar 2018

👍1

The responsiveness to core updates reflects well on the community. Great work people.

On Mar 12, 2018, at 10:26 AM, Matt Condon notifications@github.com wrote:

Seems like a reasonable task for an "update to 0.4.21" pull request, once 0.4.21 has been in the wild for a bit

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/OpenZeppelin/zeppelin-solidity/issues/807#issuecomment-372393771, or mute the thread https://github.com/notifications/unsubscribe-auth/Agl2IITa_TGcovSmJ27vPOVruUAYxQZeks5tdq_bgaJpZM4SlcBS.

Idiotcards on 12 Mar 2018

@Shrugs do you have an ETA for this to be released? Thank you

aleybovich on 17 Mar 2018

Is this open?

wildaces215 on 2 Apr 2018

It depends on what is expected from this PR (#863). Because it only fixes part of the compiler warnings from the new soidity compiler.

DumasV on 4 Apr 2018

This can probably be closed with the improvements here https://github.com/OpenZeppelin/zeppelin-solidity/pull/876

icole on 12 Apr 2018

👍1

thanks @icole! I had forgotten about this issue :)

shrugs on 12 Apr 2018

when this fix will be released?

kirillDanshin on 12 Apr 2018

It will be published in version 1.9.0, currently scheduled for 1.5 weeks from now

shrugs on 12 Apr 2018

👍1

how we can use this feature right now?

kirillDanshin on 12 Apr 2018

you can point your local project to the master branch of zeppelin-solidity

npm install git://github.com/OpenZeppelin/zeppelin-solidity.git#master --save

shrugs on 12 Apr 2018

😕2

Why not bump minor version number for this? Warnings from a library are a silly thing, I'd love to get updates through npm proper... (adding master branch from git to package.json is obviously not wholly satisfactory since npm i might later break things). I'll just npm install git://github.com/OpenZeppelin/zeppelin-solidity.git#8f2a4785 --save-dev for now then.