As a user, I'd expect that BurnableToken when called burn(uint _value) method, it should fire
Transfer(msg.sender, address(0), value); event.
the same as MintableToken does when it fires mint(to, value)
https://github.com/OpenZeppelin/zeppelin-solidity/blob/master/contracts/token/ERC20/MintableToken.sol#L35
Transfer(address(0), _to, _amount);
Thoughts?
Is it a transfer though, it reads to me as a complete destruction of the burned token, rather than movement of it to a 0 address.
I think it should have it! we had to change the burn method in the LifToken implementation to add the burn function.
@rstormsf can you go ahead and create the PR? assign me as reviewer pls.
@AugustoL done
Most helpful comment
@rstormsf can you go ahead and create the PR? assign me as reviewer pls.