Openzeppelin-contracts: BurnableToken doesn't fire Transfer event

Created on 13 Feb 2018  路  4Comments  路  Source: OpenZeppelin/openzeppelin-contracts

  • [x] 馃搱 This is a feature request.

    馃帀 Description

As a user, I'd expect that BurnableToken when called burn(uint _value) method, it should fire
Transfer(msg.sender, address(0), value); event.

https://github.com/OpenZeppelin/zeppelin-solidity/blob/master/contracts/token/ERC20/BurnableToken.sol#L18

the same as MintableToken does when it fires mint(to, value)
https://github.com/OpenZeppelin/zeppelin-solidity/blob/master/contracts/token/ERC20/MintableToken.sol#L35

    Transfer(address(0), _to, _amount);

Thoughts?

Most helpful comment

@rstormsf can you go ahead and create the PR? assign me as reviewer pls.

All 4 comments

Is it a transfer though, it reads to me as a complete destruction of the burned token, rather than movement of it to a 0 address.

I think it should have it! we had to change the burn method in the LifToken implementation to add the burn function.

@rstormsf can you go ahead and create the PR? assign me as reviewer pls.

@AugustoL done

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Flash-Git picture Flash-Git  路  3Comments

ryana picture ryana  路  4Comments

mswezey23 picture mswezey23  路  3Comments

bh2smith picture bh2smith  路  4Comments

sanchaymittal picture sanchaymittal  路  4Comments