Opentx: Companion: Highlight orphaned logical switches in red

Created on 21 Sep 2019 · 9Comments · Source: opentx/opentx

When changing complex model setups it can happen that some of the logical switches get "orphaned" meaning they are not referenced by anything (not SF nor other logical switches).

If such switches would be highlighted in Companion this would help to show errors or remnants.

I just changed the way I turn on/off logging in one of my setups.

This means that part of the former logic may or may not be addressed anymore.
I don't dare to just remove the logical switch because it could be referenced for some other purpose as well.
This means I need to reconstruct the logic of the whole model, which is not only time consuming, but would also make it easier to make a mistake.

Companion highlighting a referenced switch would help

Source

notlebowski

👍1

All 9 comments

Orphaned references can occur in a number of areas and implementing for logical switches is likely to spawn requests for other reference checks. Performing lots of cross checks would slow down model loading and refreshing after every field change. Also colour coding is significant dev work.
My vote would be for a model 'audit' function.

elecpower on 23 Sep 2019

It says "Companion"

An improvement spawning requests for other improvements is a poor argument IMHO for not doing it.

notlebowski on 24 Sep 2019

👍1

Is it possible to find this dependency in the LUA scripts?

Tygrys-1 on 29 Sep 2019

Its strength would come from having it all the time (in Companion)
If suddenly one of the switches turns red, you may be doing something wrong.

notlebowski on 30 Sep 2019

👍1

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] on 28 Mar 2020

I think that this feature would help with complex setups and would help to avoid mistakes when editing them in Companion.

notlebowski on 31 Mar 2020

I am interested to find out what the view of devs are regarding this.

notlebowski on 31 Mar 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] on 27 Sep 2020

To me this seems like a desirable feature. If it is implemented in Companion I would think this is surely sufficient and would not harm any computing ressources in the transmitter.
I already stumbled across orphaned LS and was wondering why no mechansim throws a warning or a hint. However this does not necessarily need to be red highlighted or whatever.