Opentelemetry-specification: [meta] Do not "Require branches to be up to date before merging" in the repository settings

Created on 11 Mar 2020  路  8Comments  路  Source: open-telemetry/opentelemetry-specification

I think this setting has little benefit since the spec build is unlikely to be broken because of logically but not textually conflicting PRs. On the other hand I can see a few drawbacks:

  • it is not possible to allow maintainers to update PRs that originate from an organization repository (as opposed to personal repository)
  • every time someone presses update, the diff does not change but the PR uselessly pops up in everyone's notifications.

Most helpful comment

TC decided to try this one. Lets see how it goes and adjust if/as needed ;)

All 8 comments

This sounds sensible.

This also sounds like a reasonable thing to me for this specification repo.

Please note that the "Allow edits from maintainers" option is not available for forks that live in organizations, it's only available for private repositories, so that won't solve the problem of merging being hindered in these cases.

TC decided to try this one. Lets see how it goes and adjust if/as needed ;)

Why was this re-enabled?

Because we fixed the lint check (broken for 2 months) and started to merge PRs that did not pass the lint check (based on master commit that did not include the fix). This was the only option to enforce that everyone pass the lint check.

See #847 and #845

Closing this issue because we explained the reasoning, and we have clear contributions guidelines that do not have this problem

Was this page helpful?
0 / 5 - 0 ratings