Opentelemetry-js: Convert http and https plugin to instrumentation - it should become one package only now

Created on 5 Nov 2020  路  6Comments  路  Source: open-telemetry/opentelemetry-js

  • Change folder name from opentelemetry-plugin-* to opentelemetry-instrumentation-*
  • Change package name from @opentelemetry/plugin-* to @opentelemetry/instrumentation-*
  • Change implementation to use InstrumentationBase
feature-request

Most helpful comment

@open-telemetry/javascript-approvers please decide about name for combined instrumentation for http and https plugin
My proposition is
@opentelemetry/instrumentation-http

All 6 comments

@open-telemetry/javascript-approvers please decide about name for combined instrumentation for http and https plugin
My proposition is
@opentelemetry/instrumentation-http

+1 @opentelemetry/instrumentation-http

I will try to work on this this weekend

EDIT: @obecny you mentionned the java approvers :/

Also i forgot to mention it in SIG but we need to think about how to strategy to migrate from our current plugin loader to the next instrumentation system.

For web plugins I will try to make it 100% backwards compatible - the code people have should not require any change. Will see how it goes and if that requires any changes in web tracer provider will do that too, but hard to say now yet.

I will try to work on this this weekend

EDIT: @obecny you mentionned the java approvers :/

typo :/

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rbruggem picture rbruggem  路  5Comments

naseemkullah picture naseemkullah  路  7Comments

naseemkullah picture naseemkullah  路  4Comments

maxmil7 picture maxmil7  路  5Comments

naseemkullah picture naseemkullah  路  5Comments