Opentelemetry-js: Question about automatic metrics collection.

Created on 28 Jan 2020  路  4Comments  路  Source: open-telemetry/opentelemetry-js

  • [ ] This only affects the JavaScript OpenTelemetry library
  • [x] This may affect other libraries, but I would like to get opinions here first

Regarding automatic metrics collection for libs...

will outgoing requests be measured as well as incoming requests? I presume for express, only incoming requests would be measured and errors counted, whereas for axios or request type libs, outgoing requests/errors would be measured. Is that right??

Whereas the http plugin would measure both incoming and outgoing?

Discussion

All 4 comments

This is all yet to be decided by the spec I think, but the simple answer is that we can collect as many metrics as we want as long as they are properly namespaced.

Indeed we can't speak about OT specs but for your information, OC specs required to have different metrics for incoming/outgoing requests (see node impl)

@naseemkullah if your question is answered can you close this issue? If not, then please let us know.

It is, thanks!!

Was this page helpful?
0 / 5 - 0 ratings