Opentelemetry-java: Inconsistency in tests static imports, need to document what to use

[bogdandrutu]

I saw usages of:

import static org.junit.Assert.assertEquals;

// AND

import static org.junit.jupiter.api.Assertions.assertEquals;

import static org.assertj.core.api.Assertions.assertThat;

// AND

import static org.assertj.core.api.AssertionsForClassTypes.assertThat;  // a simple replace of Assertions works.

[jkwatson]

We, in my opinion, should standardize on assertj with import static org.assertj.core.api.Assertions.assertThat;

[bogdandrutu]

what about assertEquals which one should we use?

[kenfinnigan]

I've found all the assertX() methods with assertj to be far easier to use than the ones with JUnit 5

[Oberon00]

what about assertEquals which one should we use?

assertThat(x).isEqualTo(y). Has the great advantage that you don't get expected vs actual wrong about 40% of the time 😄

[jkwatson]

what about assertEquals which one should we use?

I think we shouldn't use either of them, and just stick with assertj