Opentelemetry-java: Rename `HttpTextPropagator` to `TextMapPropagator`.

Created on 24 Aug 2020  路  4Comments  路  Source: open-telemetry/opentelemetry-java

See: https://github.com/open-telemetry/opentelemetry-specification/pull/793

good first issue help wanted p2 required-for-ga
Source
picture carlosalberto
👍2

Most helpful comment

I suggest we go with Propagator instead of Format as suffix.

@open-telemetry/java-approvers opinions on this?

picture carlosalberto on 25 Aug 2020
👍4

All 4 comments

Do you mean HttpTextFormat? It seems that this repository does not have classes with HttpTextPropagator that name.

dengliming picture dengliming on 24 Aug 2020
👍1

HttpTextFormat -> TextMapFormat
MultiHttpTextFormat -> MultiTextMapFormat
CustomHttpTextFormat -> CustomTextMapFormat
NoopHttpTextFormat -> NoopTextMapFormat

or

HttpTextFormat -> TextMapPropagator
MultiHttpTextFormat -> MultiTextMapPropagator
CustomHttpTextFormat -> CustomTextMapPropagator
NoopHttpTextFormat -> NoopTextMapPropagator

?

malafeev picture malafeev on 25 Aug 2020
👍1

I prefer *Propagator this one.

dengliming picture dengliming on 25 Aug 2020

I suggest we go with Propagator instead of Format as suffix.

@open-telemetry/java-approvers opinions on this?

carlosalberto picture carlosalberto on 25 Aug 2020
👍4
Was this page helpful?
0 / 5 - 0 ratings

Related issues

z1c0 picture z1c0  路  3Comments
chrvo picture chrvo  路  4Comments
songy23 picture songy23  路  3Comments
jkwatson picture jkwatson  路  3Comments
anuraaga picture anuraaga  路  4Comments