Opentelemetry-dotnet: Use TreatWarningsAsError

Created on 19 Jun 2019  路  5Comments  路  Source: open-telemetry/opentelemetry-dotnet

Building the solution now triggers a ton of warnings
Suggest to turn on <TreatWarningsAsErrors>True</TreatWarningsAsErrors> and clean up the current warnings.

good first issue help wanted
Source
picture bruno-garcia

All 5 comments

I'd take this - it's going to be a huge changeset...!

Do we really want to prefix all local calls with this?

enzian picture enzian on 2 Jul 2019

It'd be great to use _ instead of this. I'd be glad to make the change if that's the blocker for changing it.

bruno-garcia picture bruno-garcia on 2 Jul 2019

It'd be great to use _ instead of this.

@bruno-garcia: I wish for a refactoring the does that directly ;-)

enzian picture enzian on 2 Jul 2019

Do we want to force the explicit declaration of access modifiers throughout the codebase?

enzian picture enzian on 2 Jul 2019
👍1

Since #131 is #137 is the follow up to this, can we close this one?

enzian picture enzian on 9 Jul 2019
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

guitarrapc picture guitarrapc  路  3Comments
yallie picture yallie  路  6Comments
cijothomas picture cijothomas  路  4Comments
fbeltrao picture fbeltrao  路  5Comments
ddiaz-relativity picture ddiaz-relativity  路  4Comments