Opentelemetry-dotnet: Tracer.StartActiveSpanFromActivity does not copy Activity.Tags

[fbeltrao]

When creating a Span from an activity the tags are not copied. Application Insights, copies it (Tracer.StartActiveSpanFromActivity vs TelemetryClient.StartOperation)

[brunomasantos]

I would like to make contributions to this project. Wondering if I can pick this up?

Just to be clear, the objective is to copy the Activity.Tags for the Span.Attributes?
If so, is this something that should be configurable with SpanCreationOptions to maintain coherency with other methods or to be the default behaviour?

[SergeyKanzhelev]

@brunomasantos I think it would be beneficial to have it as a default behavior. Thank you!

CC: @tarekgh

[tarekgh]

Just a small note, Span.Attributes internally defined as EvictingQueue. Would be nice if we can add a constructor to EvictingQueue which takes IEnumerable returned from Activity.Tags so we don't have to call Span.SetAttribute for each item in the tags.

[brunomasantos]

Can you take a look at https://github.com/open-telemetry/opentelemetry-dotnet/pull/572 to see if it is the desired approach to solve the issue?

[tarekgh]

I added a minor comment there.

Also, I added a question to @SergeyKanzhelev https://github.com/open-telemetry/opentelemetry-dotnet/pull/572#discussion_r404423390