Openstreetmap-carto: Public transport shelter should not be labeled with elevation

Created on 22 Dec 2020  ·  5Comments  ·  Source: gravitystorm/openstreetmap-carto

Expected behavior

A bus shelter tagged amenity=shelter building=yes shelter_type=public_transport should be rendered as an ordinary building with or without an ele tag.

Actual behavior

The ele tag causes the bus shelter to be rendered like an alpine hut, labeled with a 🌧️ and an elevation. For example, this way was added as part of a building import that included elevations and heights for every building. The bus shelter is useful for avoiding the rain, but the elevation is not particularly interesting for a 2D renderer. (It might be useful for a 3D renderer.)

Links and screenshots illustrating the problem

vta

/ref #3382

amenity-points good first issue

Most helpful comment

Quick mockup: side-view of a back wall with a tilted roof, supposed to be transport-blue. Do we need the raindrops?
shelter-pt1

All 5 comments

Thanks for the report. There seem to be a few misconceptions here:

  • The shown rendering is not the rendering for alpine huts - alpine huts are rendered like this: https://www.openstreetmap.org/#map=17/46.50142/8.05286
  • The addition of the ele tag does not change the rendering beyond displaying the elevation in the label in addition to the name (or alone if no name is tagged).
  • The rendering of the building is completely independent of the shelter and ele tagging.

I think this issue could still make sense in the following versions:

  • propose to not render ele on amenity=shelter + shelter_type=public_transport - that makes quite a lot of sense IMO.
  • propose not to render shelter_type=public_transport with a symbol - i don't think that is a good idea because those shelters (whether they qualify as building or not) are fairly useful to map users.
  • propose to render shelter_type=public_transport with a symbol distinct from ordinary amenity=shelter. That in principle makes sense IMO but would depend on a suitable symbol of course.

I'd prefer "_render shelter_type=public_transport with a symbol distinct from ordinary amenity=shelter_" as well as "_not render ele on amenity=shelter + shelter_type=public_transport_".

Quick mockup: side-view of a back wall with a tilted roof, supposed to be transport-blue. Do we need the raindrops?
shelter-pt1

Thank you for clearing up my misunderstanding. Indeed, I meant to suggest omitting the elevation from shelter_type=public_transport, but a distinct icon would be even better. The mockup makes sense to me; hopefully it would be intuitive regardless of which side of the road the shelter is on.

Ok, i changed the title to reflect the idea or removing the elevation label - that is non-controversial and a good first issue for new developers. Differentiated rendering of different shelter_type values is more tricky to do in an intuitive fashion.

Was this page helpful?
0 / 5 - 0 ratings