Openstreetmap-carto: Release v5.0.0

[jeisenbe]

Now that the schema_changes branch has been merged to master, the next release will be a major version which will require a database reload for style users.

It has been suggested that we should also make a couple more changes prior to this release:

1) Move all .mss files to a new subdirectory - issue #4041

• PR #4047

2) Change required Mapnik and Carto versions - https://github.com/gravitystorm/openstreetmap-carto/pull/3399#issuecomment-591887282

• Raise to Mapnik 3.0.22 and Carto 1.2.0 to allow new features like global pattern alignment, handling surfaces properly
• Can wait a few months - see https://github.com/gravitystorm/openstreetmap-carto/issues/4046#issuecomment-593798852

3) Merge #4042 - though changes are requested at the moment

Are there any other things that need to happen before v5.0.0 is released? It would be nice to do it this week or next.

(I'm aware that I will need to rebase my open PRs afterward, and that's fine.)

[jeisenbe]

1. Merge #4042 - though changes are requested at the moment - done

[pnorman]

• @pnorman - are you planning to do this?

Yes.

I want to sort out #4042 before 5.0.0 as well.

I'm against requiring a Mapnik that's not in Ubuntu LTS, particularly when we don't have features that need it yet.

[sommerluk]

On the other hand the new Mapnik _will_ be in Ubuntu 20.04 LTS which will (as far as announced) be out in only seven weeks… Might be worth to wait?

[pnorman]

On the other hand the new Mapnik _will_ be in Ubuntu 20.04 LTS which will (as far as announced) be out in only seven weeks… Might be worth to wait?

We can release a new major version when 20.04 is out and people have had time to move to it.

[sommerluk]

Okay. What would be a reasonable time frame for that?

[pnorman]

Okay. What would be a reasonable time frame for that?

I'm not sure - probably a month or two after, depends how many 5.x releases we want to do.

---

#3719 is something I want to get in to 5.x

[jeisenbe]

2 last PRs which we need to merge are #4055 and #4056, though I need to fix the lua tests for #4055 still. After that perhaps @pnorman can get the release done for this major version change?

[jeisenbe]

4055 is closed, replaced by the approved PR #4075, and #4056 is closed, so I believe everything is ready?

[pnorman]

I'd like to wait a few days to give any new bugs a chance to shake out. I'll tag it during the week.

[pnorman]

Absent anything new, I'll tag 5.0.0 after work

[pnorman]

I upgraded to a new dev machine and I have to figure out why I'm not getting anything with the shapefiles loading when I use kosmtik

[jeisenbe]

I'm not getting anything with the shapefiles loading when I use kosmtik

Do you mean the oceans and icesheets are not visible?

Did you upgrade to a newer version of Mapnik and Carto?

You might need to delete the shapefile indexes.

See comment: https://github.com/gravitystorm/openstreetmap-carto/pull/3399#issuecomment-544245098

Also see #3717 and https://github.com/gravitystorm/openstreetmap-carto/issues/3717#issuecomment-518592387

But see my experience with deleting the .index files for the shapefiles: https://github.com/gravitystorm/openstreetmap-carto/pull/3399#issuecomment-541336376 with this suggested solution https://github.com/gravitystorm/openstreetmap-carto/pull/3399#issuecomment-544245098 - which I haven't tried yet.

[pnorman]

Did you upgrade to a newer version of Mapnik and Carto?

I did a clean install, but the version of shapeindex my system has is from an older version of Mapnik than Kosmtik uses because node-mapnik is including a binary blob for some unreleased version of Mapnik

You might need to delete the shapefile indexes.

I'll try that after work

[jeisenbe]

Besides re-importing the rendering database, will style users need to take any additional action to update the route=ferry indexes when switching to v5.0.0?

[pnorman]

will style users need to take any additional action to update the route=ferry indexes when switching to v5.0.0?

No. All their indexes will be gone, they just need to recreate them like normal

[pnorman]

Done.