Openstreetmap-carto: amenity=parking rendered with two parking icons

[Prince-Kassad]

This also seems to be related to our switch to ST_PointOnSurface.

Example: https://www.openstreetmap.org/#map=18/51.94370/13.89742

[kocio-pl]

Could anyone review _all_ the changes from #3712 then in a systematic way, so we know what else can be broken?

[imagico]

This is probably due to parkings being both in amenity-points and amenity-low-priority-poly - which has been the case before #3712 but did not show up because the placement was identical.

In other words: #3712 revealed a coding error that was present before.

amenity-low-priority and amenity-low-priority-poly need to be reviewed for duplicates with amenity-points (and possibly merged into one layer just like amenity-points).

[jragusa]

This also affects other features such as buildings (I guess):

https://www.openstreetmap.org/way/452206220

https://www.openstreetmap.org/way/225166573

[imagico]

@jragusa - this is already known, see https://github.com/gravitystorm/openstreetmap-carto/pull/3781#pullrequestreview-236378201. In principle there is nothing wrong with displaying both building name/POI and address but in this form this is of course confusing - see https://github.com/gravitystorm/openstreetmap-carto/issues/3780#issuecomment-491362430

[pnorman]

This also affects other features such as buildings (I guess):

This has been fixed with #3781

[Grillmannen]

Copied from issue 3866 referenced above:

Expected behavior

A parking lot should only be rendered with a P once on the centroid of the area

Actual behavior

In the example it's rendered twice with no visible data error

Links and screenshots illustrating the problem

https://www.openstreetmap.org/way/116351847
https://www.openstreetmap.org/#map=19/56.06334/12.70951

[jeisenbe]

Looks like we need to fix this one; lots of reports about the same problem.

Should we merge the amenity-low-priority-poly and amenity-low-priority layers at the same time?