Openstreetmap-carto: Add rendering for leisure=ice_rink

[matthijsmelissen]

Some leisure objects are not rendered, such as:

• leisure=ice_rink (https://trac.openstreetmap.org/ticket/3482)
• leisure=dog_park (https://trac.openstreetmap.org/ticket/2482)

[matkoniecz]

dog_park is covered by #341, it would be better to track other leisure=* tags separetely

[jragusa]

https://www.openstreetmap.org/way/381191895

Pitch colour:

Glacier colour:

However, I still have a problem to render name from landcover.mss

[matkoniecz]

However, I still have a problem to render name from landcover.mss

From looking at https://github.com/jragusa/openstreetmap-carto/commits/ice_rink text code is not added yet.

One relatively easy way to do that is to look how similar feature is implemented, in this case pitch is likely to be a good template.

So lets search for a pitch: https://github.com/gravitystorm/openstreetmap-carto/search?q=pitch&type=Code

It should find, among other amenity-points where labels are defined (unfortunately, also labels for areas) - see https://github.com/gravitystorm/openstreetmap-carto/blob/0a041fa7be9be209efb3727b00050d68cc94bca3/amenity-points.mss#L1915

Comment if you need further help.

[jragusa]

Thank you very much @matkoniecz

I didn't know this feature to find code in the project. This helped me a lot

With name rendered
https://www.openstreetmap.org/way/87188308

[HolgerJeromin]

Many ice rinks in germany are buildings:
https://www.openstreetmap.org/way/33498620

I have no preference what to do with them, but this should be considered.

[Tomasz-W]

A green leisure=sports_centre label is an option, but then we have to choose do we want it also for simple open-air ice rinks (green label on blue area may look bad, but it is always good to see a test rendering to decide)

[jragusa]

The rendering is the same than both building=* and leisure=sports_centre: they are basically rendered as building (area and label). The new rendering is only available for outdoor ice_rink

edit: only shop=mall has a distinct label rendering on building.

[jragusa]

Following suggestion of @Tomasz-W with pitch colour for label:

[Tomasz-W]

I vote for green text, because ice in leisure=ice_rink is more a leisure (sport) feature than a natural feature.

[Tomasz-W]

@jragusa Are you going to make a PR for this issue?

[jragusa]

@Tomasz-W done :)