Openstreetmap-carto: Add rendering for leisure=fishing

[IgorEliezer]

"Fish & Pay" (leisure=fishing) is a leisure facility for fishing as entertainment. People normally pay an entrance fee or by catch weight. It's similar to landuse=recreation_ground but with man-made or natural pounds.

I suggest using the same pattern for landuse_recreation_ground and this as icon.

Links:

• Wiki: https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dfishing
• Taginfo: https://taginfo.openstreetmap.org/tags/leisure=fishing
• Tag count: 5 026, more than beach_resort, outdoor_seating and bird_hide.
• Examples: w607102421 and w544102360
• Search: https://www.google.com/search?q=Fish+%26+Pay

[Adamant36]

Good idea. The page says its still a draft though. So that might be an issue. Plus, half are mapped as points. So if it is render, it would be good to have an icon for it.

[IgorEliezer]

it would be good to have an icon for it.

Sure. This one would do, which is the same used by Google Maps:

https://wiki.openstreetmap.org/wiki/File:MUTCD_RS-063.svg

[Adamant36]

Its not a bad icon. We cant use anything related to Google Maps though because its copyrighted. So we will have to see if someone is willing to create an icon. The draft thing needs to be resolved to though. I think thats more important then if we have an icon for it or not at this point.

[IgorEliezer]

We cant use anything related to Google Maps though because its copyrighted.

The icon is from Wikimedia Commons (https://commons.wikimedia.org/wiki/File:MUTCD_RS-063.svg, under public domain license), which happens to look like Google Maps' counterpart, I mentioned this just to point out there'd be a consistency across platforms. :)

[Tomasz-W]

Icon proposals:

1. 
2. 
3. 
4. 

[kocio-pl]

2 is too close to the fish shop, I like 3 the most.

[IgorEliezer]

I like 4 the most, for the hook close to fish mouth depicts better the "fishing" idea and resembles more the fishing sign, IMO. 3 seems a bit stacked, but still does. :+1:

[Adamant36]

@dieterdreist, can you give your opinion on why this shouldn't be rendered please? And can someone explain what the advantages of rendering this versus fishing=yes is or why the draft status doesn't matter to rendering it or not? Thanks.

[IgorEliezer]

And can someone explain what the advantages of rendering this versus fishing=yes is (...)

From what I understood by reading the wiki and what I've found while mapping:

• fishing=yes|no|customers|private|etc is about access control of a water body.
• leisure=fishing is about a facility which may contain pounds (natural=water + water=pond + fishing=customers), buildings, shelters etc. So I guess if a pound within the "Fish & Pay" grounds is not for customers to use, I could use fishing=no.

[Adamant36]

@IgorEliezer HHmmm OK. Makes sense. The fact that it is a draft makes it seem like it still wasn't decided on though. Although, I still do see a use for this being rendered. My question would be if it is also mapped in places like beaches or sides of rivers where people might fish, but there is also other uses. If its only used for exclusive fishing landuses I'm fine with that. There should be a key for places like that though. I almost think a point like there is for tourist viewpoints would be better then mapping it as an area.

Perhaps you could address the concerns raised by Dieterdreist on the wiki page. I think he makes some valid points against it. Although, I don't know why he didn't bring them up here instead.

[dieterdreist]

sent from a phone

On 16. Sep 2018, at 02:45, Adamant36 [e-mail] wrote:

@dieterdreist, can you give your opinion on why this shouldn't be rendered please?

I am not generally opposed to rendering fishing facilities, but I think the tag is not chosen well. „fishing“ is an activity, not a facility or place. For leisure we use places, not activities.

[IgorEliezer]

I am not generally opposed to rendering fishing facilities, but I think the tag is not chosen well. (...)

I was thinking something around these lines too. Plus, the wiki page "Tag:leisure=fishing" doesn't help much either; all it says is "Place for fishing." and mixes up access tag fishing=* with the leisure tag. The whole "Gallery" section should be moved to "Key:fishing".

A pound with fishing=yes doesn't make the whole fishing place facility as it may encompass not only lakes or pounds but also a building to receive customers, a small fishing shop, a parking lot, shelters, benches, barbecue apparatuses etc. Here in Brazil we have these as I described by the hundreds.

If fishing is allowed in a water body but there aren't amenities and apparatuses or if fishing isn't the main activity (e.g. a pound in a park or camping site where fishing is allowed), natural=water + fishing=yes suffices.

I'm for postponing the rendering proposal to fix the tag if need be.

[Tomasz-W]

Gist link: https://gist.github.com/Tomasz-W/58cdeee87a3e4f767d699955bd1caa35

[Adamant36]

@IgorEliezer, have you done any research on how the tag is actually used or figure out the wiki issue yet? I did a review of places tagged leisure=fishing in America and it seemed to really the gambit. There was a lot of points on the sides of lakes, beachs, and piers tagged with it. Only a few fit the discription of the tag you gave. I was planning on doing the PR for it, but id like it to be figured out first, or if not, the issue should be closed as wont add. I think rendering it over things like beaches or piers is problematic, even if it is misstagging. Which really isnt even clear. So maybe the issue should be closed anyway.

[Adamant36]

I did some tests on it. I coded it similar rendering to the swimming area PR so it doesn't have a fill color. In general, I think it looks cool and gives an opportunity to render some unique places. The tag has also had a pretty meteoric rise in usage, as can be seen by the chart. its currently at 5,068 uses and seems to be going up very steadily. So I think its worth doing a PR for. Since both the usage numbers and need for it are clearly there. Whatever the exact issue with what does or doesn't qualify will probably be worked out over time and its not like other tags on the map don't suffer from some miss-usage anyway.

Nodes at z18


ways at z18

I think the first way example is miss-tagged, or maybe both are since the page says it doesn't apply to areas, but I like how it looks anyway. Especially on piers, since it gives them the context of leisure usage that normal piers with boats attached to them don't have.

[IgorEliezer]

@Adamant36:

have you done any research on how the tag is actually used or figure out the wiki issue yet?

As to how the tag is used, outside my country, no. Doing a plain query with "leisure"="fishing" will bring, like you said, mixed results. At least 1/3 of occurrences are leisure=fishing used directly in lakes and pounds, which I consider miss-tagging probably due to bad documentation on the wiki.

Querying way["leisure"="fishing"][!"natural"] (!natural is to exclude lakes) on Overpass brings results that fit better the criteria I gave. See examples below.

Even with laconic documentation, for me the "leisure=" key implies a facility or area with some kind of man-made structures and equipment, not just a spot in a water body, while "fishing=" would mean whether fishing is allowed or not.

Examples that fit in my criteria:

England:
https://www.openstreetmap.org/way/72241981
https://www.openstreetmap.org/way/242986416
https://www.openstreetmap.org/way/415311118

Germany:
https://www.openstreetmap.org/way/269516459 (:star:)
https://www.openstreetmap.org/way/24897251
https://www.openstreetmap.org/way/27410781

Brazil:
https://www.openstreetmap.org/way/262553727 (:star:)
https://www.openstreetmap.org/way/517951568
https://www.openstreetmap.org/way/198198187

All in all, please no hurry, and your testings are much appreciated. :+1:

[HolgerJeromin]

We should not hide tagging errors but make them visible...

[Adamant36]

@HolgerJeromin, I totally agree. That's why I think it might be worth rendering despite the tagging issues. As it would potentially give mappers a chance to fix them. Along with maybe drawing them into creating a better definition of the tag on the wiki.

[IgorEliezer]

@Adamant36, ~it seems we'll have a release this Friday. Is it a good idea to try this new feature?~

Sorry, I mistook a month ahead Friday with this Friday.

[kocio-pl]

23.11 is a month from now, see #3476... :smile:

[IgorEliezer]

23.11 is a month from now, see #3476...

Oops, sorry. I mistook a month ahead Friday with this Friday. Thanks for pointing out. :+1:

[Adamant36]

@IgorEliezer, I'll be sure to do something on it before then.